Skip to content

SRVKP-9789: Fix sidebar list bullets for PipelineRuns and Triggers in Topology Page#1020

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:mainfrom
ankrsinha:fix/SRVKP-9789-main
Apr 7, 2026
Merged

SRVKP-9789: Fix sidebar list bullets for PipelineRuns and Triggers in Topology Page#1020
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:mainfrom
ankrsinha:fix/SRVKP-9789-main

Conversation

@ankrsinha
Copy link
Copy Markdown
Contributor

Overview

The Topology → Resources sidebar displayed unintended default list bullets for:

  • PipelineRuns
  • Triggers

This was caused by the use of raw <ul> and <li> elements and legacy classes (list-group, list-group-item), which resulted in unintended list styling.


Changes Made

Replaced legacy list rendering with PatternFly components and removed default browser styling.

  • Replaced <ul>/<li> with PF List / ListItem

  • Removed:

    • list-group
    • list-group-item
    • pipeline-overview custom classes
  • Ensured consistent spacing and alignment using PF


Before Fix

topology-sidebar-main-before-fix.mp4

After Fix

topology-sidebar-main-after-fix.mp4

… Topology page

- Replace ul/li tags with PF6 List/ListItem in PipelineOverview, TriggersOverview, and PipelineRunItem.
- Stop default list markers on the Topology Resources tab for those sections.
- Drop legacy list-group-item and pipeline-overview classes on those rows for consistent PF6 styling.

Signed-off-by: Ankur Sinha <anksinha@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Apr 2, 2026

@ankrsinha: This pull request references SRVKP-9789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Overview

The Topology → Resources sidebar displayed unintended default list bullets for:

  • PipelineRuns
  • Triggers

This was caused by the use of raw <ul> and <li> elements and legacy classes (list-group, list-group-item), which resulted in unintended list styling.


Changes Made

Replaced legacy list rendering with PatternFly components and removed default browser styling.

  • Replaced <ul>/<li> with PF List / ListItem

  • Removed:

  • list-group

  • list-group-item

  • pipeline-overview custom classes

  • Ensured consistent spacing and alignment using PF


Before Fix

topology-sidebar-main-before-fix.mp4

After Fix

topology-sidebar-main-after-fix.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ankrsinha
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

/retest

@anwesha-palit-redhat anwesha-palit-redhat removed the request for review from pratap0007 April 6, 2026 09:55
Copy link
Copy Markdown
Contributor

@arvindk-softwaredev arvindk-softwaredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks Good to Me Label label Apr 7, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankrsinha, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Label for Approved PRs label Apr 7, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 53b9ee3 into openshift-pipelines:main Apr 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants