SRVKP-11379: Fix alignment of loading indicators in pipeline overview charts and pipelines metric charts#1018
Conversation
- Center loading indicators in Average Duration, Status, and Number of Runs charts. - Isolate Victory Chart wrappers from flex utilities to maintain correct SVG scaling. - Conditionally render search and toggle controls in the list page so they only appear after data is loaded. Signed-off-by: Aditya Shinde <adishind@redhat.com>
|
@adityavshinde: This pull request references SRVKP-11379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
e2e is failing |
|
/retest |
|
need before after screen recording in the pr description |
|
@adityavshinde: This pull request references SRVKP-11379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
verified that the loaders are aligned correctly for the tekton results pipeline overview page in desktop Screen.Recording.2026-04-06.at.14.39.01.mov |
anwesha-palit-redhat
left a comment
There was a problem hiding this comment.
Tested for mobile and the loader is not aligned in the container, please address this
pipelineruncardloadernotaligned.mov
* Added dynamic height and width calculations using useRef and ResizeObserver to make SVG charts fully responsive. * Solved the mobile layout bug where the loader was collapsing and not aligning properly within the container. * Ensured the loading spinner is now perfectly centered and aligned in every view (mobile, tablet, and desktop) by applying a dynamic minHeight matching the chart. * Dynamically scaled X-axis tick labels (font size, rotation angle, and padding) to prevent text overlap on smaller screens without dropping data points. Signed-off-by: Aditya Shinde <adishind@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adityavshinde The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Dynamic-height-After-fix.mp4Thank you @anwesha-palit-redhat .Made changes according to the reviews. |
|
@adityavshinde: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR improves the UI of the Pipeline Overview page during the data-fetching phase. Previously, the loading spinners in the chart cards were misaligned. This update uses PatternFly 6 flex utilities to properly center the
<LoadingInline />components both vertically and horizontally within their respective chart areas.Additionally, it prevents the search bar and pipeline/repository toggle controls from rendering prematurely on the list page while the initial data is still loading.
Behaviour ( via Screen Recording )
Before
Loader-fix-Before.mp4
After
Loader-fix-After.mp4
Jira Ticket
SRVKP-11379
Changes Made
PipelinesAverageDuration.tsx: Added PatternFly flex centering utilities (justify-content-center,align-items-center) to the loading wrapper.PipelinesRunsStatusCard.tsx: Conditionally applied centering utilities for both the Donut chart and Line chart loaders to ensure perfect alignment without breaking the loaded chart layouts.PipelinerunsNumbersChart.tsx: Centered the loading spinner for the numbers chart area.PipelineRunsListPage.tsx: Wrapped the upper controls grid (SearchInputFieldandToggleGroup) in aloadedcondition so they only appear once the underlying list data is ready.How to Test