Skip to content

SRVKP-11379: Fix alignment of loading indicators in pipeline overview charts and pipelines metric charts#1018

Open
adityavshinde wants to merge 5 commits intoopenshift-pipelines:masterfrom
adityavshinde:fix/SRVKP-11379
Open

SRVKP-11379: Fix alignment of loading indicators in pipeline overview charts and pipelines metric charts#1018
adityavshinde wants to merge 5 commits intoopenshift-pipelines:masterfrom
adityavshinde:fix/SRVKP-11379

Conversation

@adityavshinde
Copy link
Copy Markdown

@adityavshinde adityavshinde commented Apr 1, 2026

Description

This PR improves the UI of the Pipeline Overview page during the data-fetching phase. Previously, the loading spinners in the chart cards were misaligned. This update uses PatternFly 6 flex utilities to properly center the <LoadingInline /> components both vertically and horizontally within their respective chart areas.

Additionally, it prevents the search bar and pipeline/repository toggle controls from rendering prematurely on the list page while the initial data is still loading.

Behaviour ( via Screen Recording )

Before

Loader-fix-Before.mp4

After

Loader-fix-After.mp4

Jira Ticket

SRVKP-11379

Changes Made

  • PipelinesAverageDuration.tsx: Added PatternFly flex centering utilities (justify-content-center, align-items-center) to the loading wrapper.
  • PipelinesRunsStatusCard.tsx: Conditionally applied centering utilities for both the Donut chart and Line chart loaders to ensure perfect alignment without breaking the loaded chart layouts.
  • PipelinerunsNumbersChart.tsx: Centered the loading spinner for the numbers chart area.
  • PipelineRunsListPage.tsx: Wrapped the upper controls grid (SearchInputField and ToggleGroup) in a loaded condition so they only appear once the underlying list data is ready.

How to Test

  1. Navigate to the Pipeline Overview page.
  2. Throttling your network speed in the browser dev tools (e.g., set to "Slow 3G") can help visualize the loading state.
  3. Verify that the loading spinners for the Average Duration, PipelineRun Status, and Number of PipelineRuns cards are perfectly centered.
  4. Verify that the search input and toggle group at the bottom of the page do not appear until the data has finished loading.

- Center loading indicators in Average Duration, Status, and Number of Runs charts.
- Isolate Victory Chart wrappers from flex utilities to maintain correct SVG scaling.
- Conditionally render search and toggle controls in the list page so they only appear after data is loaded.

Signed-off-by: Aditya Shinde <adishind@redhat.com>
@adityavshinde adityavshinde changed the base branch from main to master April 1, 2026 11:21
@adityavshinde adityavshinde changed the title SRVKP-11379 - Fix alignment of loading indicators in pipeline overview charts and pipelines metric charts SRVKP-11379: Fix alignment of loading indicators in pipeline overview charts and pipelines metric charts Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Apr 1, 2026

@adityavshinde: This pull request references SRVKP-11379 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

This PR improves the UI of the Pipeline Overview page during the data-fetching phase. Previously, the loading spinners in the chart cards were misaligned. This update uses PatternFly 6 flex utilities to properly center the <LoadingInline /> components both vertically and horizontally within their respective chart areas.

Additionally, it prevents the search bar and pipeline/repository toggle controls from rendering prematurely on the list page while the initial data is still loading.

Jira Ticket

SRVKP-11379

Changes Made

  • PipelinesAverageDuration.tsx: Added PatternFly flex centering utilities (justify-content-center, align-items-center) to the loading wrapper.
  • PipelinesRunsStatusCard.tsx: Conditionally applied centering utilities for both the Donut chart and Line chart loaders to ensure perfect alignment without breaking the loaded chart layouts.
  • PipelinerunsNumbersChart.tsx: Centered the loading spinner for the numbers chart area.
  • PipelineRunsListPage.tsx: Wrapped the upper controls grid (SearchInputField and ToggleGroup) in a loaded condition so they only appear once the underlying list data is ready.

How to Test

  1. Navigate to the Pipeline Overview page.
  2. Throttling your network speed in the browser dev tools (e.g., set to "Slow 3G") can help visualize the loading state.
  3. Verify that the loading spinners for the Average Duration, PipelineRun Status, and Number of PipelineRuns cards are perfectly centered.
  4. Verify that the search input and toggle group at the bottom of the page do not appear until the data has finished loading.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

e2e is failing

@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

/retest

@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

need before after screen recording in the pr description

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Apr 1, 2026

@adityavshinde: This pull request references SRVKP-11379 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

This PR improves the UI of the Pipeline Overview page during the data-fetching phase. Previously, the loading spinners in the chart cards were misaligned. This update uses PatternFly 6 flex utilities to properly center the <LoadingInline /> components both vertically and horizontally within their respective chart areas.

Additionally, it prevents the search bar and pipeline/repository toggle controls from rendering prematurely on the list page while the initial data is still loading.

Behaviour ( via Screen Recording )

Before

Loader-fix-Before.mp4

After

Loader-fix-After.mp4

Jira Ticket

SRVKP-11379

Changes Made

  • PipelinesAverageDuration.tsx: Added PatternFly flex centering utilities (justify-content-center, align-items-center) to the loading wrapper.
  • PipelinesRunsStatusCard.tsx: Conditionally applied centering utilities for both the Donut chart and Line chart loaders to ensure perfect alignment without breaking the loaded chart layouts.
  • PipelinerunsNumbersChart.tsx: Centered the loading spinner for the numbers chart area.
  • PipelineRunsListPage.tsx: Wrapped the upper controls grid (SearchInputField and ToggleGroup) in a loaded condition so they only appear once the underlying list data is ready.

How to Test

  1. Navigate to the Pipeline Overview page.
  2. Throttling your network speed in the browser dev tools (e.g., set to "Slow 3G") can help visualize the loading state.
  3. Verify that the loading spinners for the Average Duration, PipelineRun Status, and Number of PipelineRuns cards are perfectly centered.
  4. Verify that the search input and toggle group at the bottom of the page do not appear until the data has finished loading.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adityavshinde
Copy link
Copy Markdown
Author

/retest

@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

verified that the loaders are aligned correctly for the tekton results pipeline overview page in desktop

Screen.Recording.2026-04-06.at.14.39.01.mov

Copy link
Copy Markdown
Contributor

@anwesha-palit-redhat anwesha-palit-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for mobile and the loader is not aligned in the container, please address this

pipelineruncardloadernotaligned.mov

* Added dynamic height and width calculations using useRef and ResizeObserver to make SVG charts fully responsive.
* Solved the mobile layout bug where the loader was collapsing and not aligning properly within the container.
* Ensured the loading spinner is now perfectly centered and aligned in every view (mobile, tablet, and desktop) by applying a dynamic minHeight matching the chart.
* Dynamically scaled X-axis tick labels (font size, rotation angle, and padding) to prevent text overlap on smaller screens without dropping data points.

Signed-off-by: Aditya Shinde <adishind@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adityavshinde
Once this PR has been reviewed and has the lgtm label, please ask for approval from anwesha-palit-redhat. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adityavshinde
Copy link
Copy Markdown
Author

Tested for mobile and the loader is not aligned in the container, please address this

pipelineruncardloadernotaligned.mov

Dynamic-height-After-fix.mp4

Thank you @anwesha-palit-redhat .Made changes according to the reviews.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@adityavshinde: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 7673809 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants