Skip to content

SRVKP-11190: Fixed the loader logic in TaskRunDetailsPage#1017

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:masterfrom
anwesha-palit-redhat:SRVKP-11190
Apr 2, 2026
Merged

SRVKP-11190: Fixed the loader logic in TaskRunDetailsPage#1017
openshift-merge-bot[bot] merged 1 commit intoopenshift-pipelines:masterfrom
anwesha-palit-redhat:SRVKP-11190

Conversation

@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

Summary

  • Fixed the loader logic in TaskRunDetailsPage so that the details page is visible for archived TaskRuns, which are only available via Tekton Results (not live Kubernetes).

Problem

The loaded state was computed as k8sLoaded && trLoaded, requiring both the Kubernetes and Tekton Results data sources to finish loading before rendering. For archived TaskRuns that no longer exist in Kubernetes, the k8s watcher would never return meaningful data, effectively blocking the page from rendering.

Fix

Changed the condition to k8sLoaded || trLoaded in TaskRunDetailsPage.tsx so that the page renders as soon as either data source has finished loading. This allows archived TaskRuns fetched from Tekton Results to display correctly without waiting on the Kubernetes loader.

Screen recording before fix

before_archived_taskrundetails_page.mov

Screen recording after fix

archived_taskrun_details_fixed.mov

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented Mar 31, 2026

@anwesha-palit-redhat: This pull request references SRVKP-11190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Fixed the loader logic in TaskRunDetailsPage so that the details page is visible for archived TaskRuns, which are only available via Tekton Results (not live Kubernetes).

Problem

The loaded state was computed as k8sLoaded && trLoaded, requiring both the Kubernetes and Tekton Results data sources to finish loading before rendering. For archived TaskRuns that no longer exist in Kubernetes, the k8s watcher would never return meaningful data, effectively blocking the page from rendering.

Fix

Changed the condition to k8sLoaded || trLoaded in TaskRunDetailsPage.tsx so that the page renders as soon as either data source has finished loading. This allows archived TaskRuns fetched from Tekton Results to display correctly without waiting on the Kubernetes loader.

Screen recording before fix

before_archived_taskrundetails_page.mov

Screen recording after fix

archived_taskrun_details_fixed.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@arvindk-softwaredev arvindk-softwaredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks Good to Me Label label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat,arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed537a7 into openshift-pipelines:master Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants