SRVKP-11190: Fixed the loader logic in TaskRunDetailsPage#1017
Conversation
…ible for archived taskruns
|
@anwesha-palit-redhat: This pull request references SRVKP-11190 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ed537a7
into
openshift-pipelines:master
Summary
TaskRunDetailsPageso that the details page is visible for archived TaskRuns, which are only available via Tekton Results (not live Kubernetes).Problem
The
loadedstate was computed ask8sLoaded && trLoaded, requiring both the Kubernetes and Tekton Results data sources to finish loading before rendering. For archived TaskRuns that no longer exist in Kubernetes, the k8s watcher would never return meaningful data, effectively blocking the page from rendering.Fix
Changed the condition to
k8sLoaded || trLoadedinTaskRunDetailsPage.tsxso that the page renders as soon as either data source has finished loading. This allows archived TaskRuns fetched from Tekton Results to display correctly without waiting on the Kubernetes loader.Screen recording before fix
before_archived_taskrundetails_page.mov
Screen recording after fix
archived_taskrun_details_fixed.mov