chore(deps): update module github.com/cenkalti/backoff/v4 to v5#973
chore(deps): update module github.com/cenkalti/backoff/v4 to v5#973red-hat-konflux[bot] wants to merge 1 commit intomainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7907c18 to
6ee1a2a
Compare
6ee1a2a to
1a7b69b
Compare
1a7b69b to
db3ddbc
Compare
4d56f46 to
db73f93
Compare
db73f93 to
3141a0f
Compare
3141a0f to
668fa6d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 78: The go.mod entry for github.com/cenkalti/backoff/v5 conflicts with
three direct deps that still require backoff v4
(github.com/openshift-online/ocm-common, github.com/openshift-online/ocm-sdk-go,
github.com/openshift/rosa); either revert the backoff line to the v4 module
path/version or upgrade those three dependencies to releases that depend on
backoff v5, update any code using the old Retry API to the v5 signatures if you
choose v5, and then run `go mod tidy` to synchronize go.sum (ensure
github.com/cenkalti/backoff/v5 is removed if reverting, or ensure all three deps
no longer reference v4 if upgrading).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
go.mod
668fa6d to
003b154
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 78: go.mod currently pins github.com/cenkalti/backoff/v5 v5.0.3 which
conflicts with all direct deps (ocm-common, ocm-sdk-go, rosa) that require
backoff/v4; fix by aligning versions: either upgrade the direct dependencies
(ocm-common, ocm-sdk-go, rosa) to releases that depend on backoff v5, or revert
go.mod to the v4 module path and version that satisfies them (e.g., replace the
github.com/cenkalti/backoff/v5 v5.0.3 entry with github.com/cenkalti/backoff/v4
at a compatible v4.x (such as v4.3.0) so go.mod matches go.sum and the three
direct deps).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
go.mod
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/briandowns/spinner v1.23.2 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.3.0 // indirect | ||
| github.com/cenkalti/backoff/v5 v5.0.3 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the module graph and go.sum to verify backoff dependency resolution
echo "=== Checking module graph for backoff dependencies ==="
go mod graph | grep 'cenkalti/backoff' | sort | uniq
echo ""
echo "=== Checking go.sum for backoff entries ==="
grep 'cenkalti/backoff' go.sum || echo "No backoff entries in go.sum"
echo ""
echo "=== Verifying direct dependencies require which backoff version ==="
echo "Checking ocm-common v0.0.34..."
go mod graph | grep 'ocm-common@v0.0.34' | grep backoff || echo "No backoff dependency found"
echo ""
echo "Checking ocm-sdk-go v0.1.496..."
go mod graph | grep 'ocm-sdk-go@v0.1.496' | grep backoff || echo "No backoff dependency found"
echo ""
echo "Checking rosa v1.2.60..."
go mod graph | grep 'rosa@v1.2.60' | grep backoff || echo "No backoff dependency found"
echo ""
echo "=== Running go mod tidy to check for issues ==="
go mod tidy -v 2>&1 | head -30Repository: openshift-online/ocm-cli
Length of output: 2988
Critical dependency conflict: backoff v5 in go.mod but v4 required by all direct dependencies.
The previous review identified this issue, but it remains unresolved. All three direct dependencies require backoff v4:
ocm-common@v0.0.34requires backoff/v4@v4.1.3ocm-sdk-go@v0.1.496requires backoff/v4@v4.1.3rosa@v1.2.60requires backoff/v4@v4.3.0
However, go.mod specifies v5.0.3, and go.sum contains only v4 entries. This creates an inconsistency where go.mod declares v5 but the actual dependency resolution pulls v4. Either upgrade the direct dependencies to versions supporting v5, or correct go.mod to specify v4.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 78, go.mod currently pins github.com/cenkalti/backoff/v5
v5.0.3 which conflicts with all direct deps (ocm-common, ocm-sdk-go, rosa) that
require backoff/v4; fix by aligning versions: either upgrade the direct
dependencies (ocm-common, ocm-sdk-go, rosa) to releases that depend on backoff
v5, or revert go.mod to the v4 module path and version that satisfies them
(e.g., replace the github.com/cenkalti/backoff/v5 v5.0.3 entry with
github.com/cenkalti/backoff/v4 at a compatible v4.x (such as v4.3.0) so go.mod
matches go.sum and the three direct deps).
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v4.3.0->v5.0.3Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
cenkalti/backoff (github.com/cenkalti/backoff/v4)
v5.0.3Compare Source
v5.0.2Compare Source
v5.0.1Compare Source
v5.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.