fix(deps): update module github.com/openshift-online/ocm-sdk-go to v0.1.498#969
Conversation
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughOpenShift module dependencies in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0c13e33 to
4069f18
Compare
715825a to
b4975a9
Compare
b4975a9 to
786db92
Compare
786db92 to
1499504
Compare
1499504 to
ad7f9ea
Compare
ad7f9ea to
0c42876
Compare
0c42876 to
b724c53
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 20: The SDK bump removed the methods ScheduleType, Schedule and NextRun
used by the upgrade-policy commands; locate every use of ScheduleType, Schedule
and NextRun (e.g. in the upgradepolicy create/list command implementations) and
replace them with the new SDK accessors per the v0.1.495 API: consult the SDK
release notes to determine the new getters/field names and call those instead
(update any nil checks and type conversions accordingly), adjust the surrounding
code in the functions that referenced ScheduleType/Schedule/NextRun so they
compile with the new method names, and run `go build`/tests to fix any further
call-site naming changes.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
go.mod
Outdated
| github.com/onsi/gomega v1.38.3 | ||
| github.com/openshift-online/ocm-common v0.0.34 | ||
| github.com/openshift-online/ocm-sdk-go v0.1.488 | ||
| github.com/openshift-online/ocm-sdk-go v0.1.495 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for usage of removed SDK fields in the codebase
echo "=== Checking for removed upgrade policy fields ==="
rg -n -C3 '\b(Schedule|ScheduleType|UpgradeType|NextRun|EnableMinorVersionUpgrades)\b' \
--type=go \
-g '!go.mod' -g '!go.sum' -g '!vendor/**' || echo "(no matches found)"
echo -e "\n=== Checking for ProvisionShard.Topology usage ==="
rg -n -C3 'ProvisionShard.*Topology|Topology.*ProvisionShard' \
--type=go \
-g '!go.mod' -g '!go.sum' -g '!vendor/**' || echo "(no matches found)"
echo -e "\n=== Checking for ProvisionShard struct usage ==="
rg -n -C3 '\bProvisionShard\b' \
--type=go \
-g '!go.mod' -g '!go.sum' -g '!vendor/**' | head -50 || echo "(no matches found)"
echo -e "\n=== Verify version v0.1.495 mentioned in go.mod ==="
grep "ocm-sdk-go" go.modRepository: openshift-online/ocm-cli
Length of output: 3256
This SDK update introduces breaking changes that will cause build failures.
The codebase actively uses methods that were removed in the updated SDK version:
ScheduleType(): Used incmd/ocm/list/upgradepolicy/cmd.go:104,cmd/ocm/create/upgradepolicy/cmd.go:153,226Schedule(): Used incmd/ocm/create/upgradepolicy/cmd.go:154NextRun(): Used incmd/ocm/list/upgradepolicy/cmd.go:106,cmd/ocm/create/upgradepolicy/cmd.go:227
The upgrade from v0.1.488 to v0.1.495 removes these methods according to release notes (v0.1.494, v0.1.492, v0.1.491). The codebase must be updated to handle the new SDK API before this dependency can be merged.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 20, The SDK bump removed the methods ScheduleType, Schedule
and NextRun used by the upgrade-policy commands; locate every use of
ScheduleType, Schedule and NextRun (e.g. in the upgradepolicy create/list
command implementations) and replace them with the new SDK accessors per the
v0.1.495 API: consult the SDK release notes to determine the new getters/field
names and call those instead (update any nil checks and type conversions
accordingly), adjust the surrounding code in the functions that referenced
ScheduleType/Schedule/NextRun so they compile with the new method names, and run
`go build`/tests to fix any further call-site naming changes.
b724c53 to
e0b2eba
Compare
2c97b00 to
4b65d12
Compare
4b65d12 to
798c4bf
Compare
….1.498 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
798c4bf to
63c077c
Compare
This PR contains the following updates:
v0.1.496->v0.1.498Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
openshift-online/ocm-sdk-go (github.com/openshift-online/ocm-sdk-go)
v0.1.498: Release 0.1.498Compare Source
OidcIssuerUrlfield to ARO-HCP Azure type for workload identity federationVisibilityfield andAzureKmsEncryptionVisibilitytype toAzureKmsEncryptionv0.1.497: Release 0.1.497Compare Source
AvailableChannelsmethod to the Version resourceConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.