Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.3#1055
Build(deps): Bump k8s.io/apimachinery from 0.34.3 to 0.35.3#1055dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
WalkthroughBumped Go toolchain in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: CI workflows are still pinning older Go versions; update the GitHub
Actions workflow steps that set go-version to match the module's "go 1.25.0"
directive by changing the go-version values to 1.25.0 in the publish-release
workflow and check-pull-request workflow (the entries currently at go-version:
1.22 / 1.23), specifically the go setup steps in publish-release.yaml and
check-pull-request.yaml so all go-version fields read 1.25.0.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5f259ad1-5648-47b0-9295-0d7228e8d3af
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only check: find places that pin or reference Go versions/toolchains.
fd -HI 'go\.mod|Dockerfile|Makefile|\.tool-versions|.*\.ya?ml$|.*\.json$' \
| xargs rg -n -C2 '(^go [0-9]+\.[0-9]+(\.[0-9]+)?$|golang:[0-9]+\.[0-9]+|setup-go|GO_VERSION|toolchain go[0-9]+\.[0-9]+)'Repository: openshift-online/ocm-cli
Length of output: 1186
Update CI workflows to use Go 1.25.0 to match the go.mod directive.
The go directive in go.mod specifies Go 1.25.0, but CI workflows pin to Go 1.22 and 1.23. Update:
.github/workflows/publish-release.yaml(line 45).github/workflows/check-pull-request.yaml(lines 51, 77)
All should use go-version: 1.25.0 to match the module directive.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, CI workflows are still pinning older Go versions; update
the GitHub Actions workflow steps that set go-version to match the module's "go
1.25.0" directive by changing the go-version values to 1.25.0 in the
publish-release workflow and check-pull-request workflow (the entries currently
at go-version: 1.22 / 1.23), specifically the go setup steps in
publish-release.yaml and check-pull-request.yaml so all go-version fields read
1.25.0.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
981899d to
713d51e
Compare
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.34.3 to 0.35.3. - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.35.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
713d51e to
1b12fd3
Compare
|
Superseded by #1097. |
Bumps k8s.io/apimachinery from 0.34.3 to 0.35.3.
Commits
72d71eaMerge remote-tracking branch 'origin/master' into release-1.35e2a2dbcBump golang.org/x/crypto to v0.45.02e9c228Merge pull request #135131 from Dev1622/sig-storage/mock-expand-flake-fixf274aacvendor: update vendor and license metadata after replacing BeTrue usage in cs...9445443Resolve lint restriction on BeTrue by introducing Succeed() with contextual e...52154f7Update vendored dependencies5a348c5KEP-5471: Extend tolerations operators (#134665)6f89492Merge pull request #133648 from richabanker/merged-discoveryc77dde2util/sort: Add MergePreservingRelativeOrder for topological sorting729c13dMerge pull request #134624 from yt2985/podcertificates-beta