Build(deps): Bump golang.org/x/text from 0.33.0 to 0.35.0#1048
Build(deps): Bump golang.org/x/text from 0.33.0 to 0.35.0#1048dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflows so their go-version entries match
go.mod (Go 1.25.0); specifically, change the go-version values in
publish-release.yaml (currently 1.23) and in check-pull-request.yaml (both
occurrences currently 1.22 and 1.23) to "1.25.0" so CI uses the module's minimum
Go version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 65b1e816-4ee1-4345-9185-343a5fee24f4
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.13 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod / go.work directives =="
rg -n --glob 'go.mod' --glob 'go.work' '^\s*go\s+[0-9]+\.[0-9]+(\.[0-9]+)?'
echo
echo "== CI/workflow/tooling pins mentioning Go versions =="
fd -HI '(^|/)(Dockerfile.*|Makefile|\.tool-versions|go\.env|.*\.ya?ml)$' | \
xargs -r rg -n 'go[ -]?version|golang:|setup-go|GO_VERSION|GOVERSION|1\.[0-9]+(\.[0-9]+)?'
echo
echo "== GitHub Actions setup-go blocks =="
fd -HI '(^|/)workflows/.*\.ya?ml$|(^|/)\.github/workflows/.*\.ya?ml$' | \
xargs -r rg -n -C2 'setup-go|go-version'Repository: openshift-online/ocm-cli
Length of output: 908
Update CI workflows to use Go 1.25.0 to match go.mod minimum version.
The go.mod change to go 1.25.0 breaks CI because workflows still pin older Go versions:
.github/workflows/publish-release.yaml:45usesgo-version: 1.23.github/workflows/check-pull-request.yaml:51usesgo-version: 1.22.github/workflows/check-pull-request.yaml:77usesgo-version: 1.23
Update all workflow go-version entries to 1.25.0 to align with the module minimum.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, Update the GitHub Actions workflows so their go-version
entries match go.mod (Go 1.25.0); specifically, change the go-version values in
publish-release.yaml (currently 1.23) and in check-pull-request.yaml (both
occurrences currently 1.22 and 1.23) to "1.25.0" so CI uses the module's minimum
Go version.
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.33.0 to 0.35.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.33.0...v0.35.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
8871f16 to
df5b8a9
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Superseded by #1090. |
Bumps golang.org/x/text from 0.33.0 to 0.35.0.
Commits
7ca2c6dgo.mod: update golang.org/x dependencies73d1ba9all: upgrade go directive to at least 1.25.0 [generated]817fba9go.mod: update golang.org/x dependencies3264de9all: clean up old Go hacks74af298all: fix tags in remaining Unicode tables117e03ball: delete old Unicode tables9463ea4all: update to Unicode 177278b25internal/export/idna: update for post-Unicode 10 idna changesf964ad8internal/export/idna: delete old code678d34eunicode/norm: preserve QC Maybe bit in packed forminfo