Skip to content

Build(deps): Bump golang.org/x/text from 0.33.0 to 0.35.0#1048

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/golang.org/x/text-0.35.0
Closed

Build(deps): Bump golang.org/x/text from 0.33.0 to 0.35.0#1048
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/golang.org/x/text-0.35.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 16, 2026

Bumps golang.org/x/text from 0.33.0 to 0.35.0.

Commits
  • 7ca2c6d go.mod: update golang.org/x dependencies
  • 73d1ba9 all: upgrade go directive to at least 1.25.0 [generated]
  • 817fba9 go.mod: update golang.org/x dependencies
  • 3264de9 all: clean up old Go hacks
  • 74af298 all: fix tags in remaining Unicode tables
  • 117e03b all: delete old Unicode tables
  • 9463ea4 all: update to Unicode 17
  • 7278b25 internal/export/idna: update for post-Unicode 10 idna changes
  • f964ad8 internal/export/idna: delete old code
  • 678d34e unicode/norm: preserve QC Maybe bit in packed forminfo
  • See full diff in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Mar 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e6ab8bb-5b9e-4f58-a916-15d7774b4988

📥 Commits

Reviewing files that changed from the base of the PR and between 8871f16 and df5b8a9.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
✅ Files skipped from review due to trivial changes (1)
  • go.mod

Walkthrough

The go.mod file was updated: Go toolchain directive moved from go 1.24.13 to go 1.25.0, two direct golang.org/x/* requirements were bumped and several indirect golang.org/x/* module versions were upgraded.

Changes

Cohort / File(s) Summary
Go Module Dependencies
go.mod
Updated Go toolchain directive go 1.24.13go 1.25.0. Bumped direct deps: golang.org/x/term v0.39.0 → v0.40.0, golang.org/x/text v0.33.0 → v0.35.0. Bumped indirect golang.org/x modules: crypto, mod, net, sync, sys, tools to newer patch/minor versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions updating golang.org/x/text from 0.33.0 to 0.35.0, which is accurate but represents only one of multiple dependency updates in the changeset that includes golang directive upgrade to 1.25.0 and several other module bumps.
Description check ✅ Passed The description directly addresses the golang.org/x/text bump from 0.33.0 to 0.35.0 with relevant commit details and links, and is clearly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/golang.org/x/text-0.35.0

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflows so their go-version entries match
go.mod (Go 1.25.0); specifically, change the go-version values in
publish-release.yaml (currently 1.23) and in check-pull-request.yaml (both
occurrences currently 1.22 and 1.23) to "1.25.0" so CI uses the module's minimum
Go version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65b1e816-4ee1-4345-9185-343a5fee24f4

📥 Commits

Reviewing files that changed from the base of the PR and between 188c8ce and 8871f16.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
module github.com/openshift-online/ocm-cli

go 1.24.13
go 1.25.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== go.mod / go.work directives =="
rg -n --glob 'go.mod' --glob 'go.work' '^\s*go\s+[0-9]+\.[0-9]+(\.[0-9]+)?'

echo
echo "== CI/workflow/tooling pins mentioning Go versions =="
fd -HI '(^|/)(Dockerfile.*|Makefile|\.tool-versions|go\.env|.*\.ya?ml)$' | \
  xargs -r rg -n 'go[ -]?version|golang:|setup-go|GO_VERSION|GOVERSION|1\.[0-9]+(\.[0-9]+)?'

echo
echo "== GitHub Actions setup-go blocks =="
fd -HI '(^|/)workflows/.*\.ya?ml$|(^|/)\.github/workflows/.*\.ya?ml$' | \
  xargs -r rg -n -C2 'setup-go|go-version'

Repository: openshift-online/ocm-cli

Length of output: 908


Update CI workflows to use Go 1.25.0 to match go.mod minimum version.

The go.mod change to go 1.25.0 breaks CI because workflows still pin older Go versions:

  • .github/workflows/publish-release.yaml:45 uses go-version: 1.23
  • .github/workflows/check-pull-request.yaml:51 uses go-version: 1.22
  • .github/workflows/check-pull-request.yaml:77 uses go-version: 1.23

Update all workflow go-version entries to 1.25.0 to align with the module minimum.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 3, Update the GitHub Actions workflows so their go-version
entries match go.mod (Go 1.25.0); specifically, change the go-version values in
publish-release.yaml (currently 1.23) and in check-pull-request.yaml (both
occurrences currently 1.22 and 1.23) to "1.25.0" so CI uses the module's minimum
Go version.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

rebase

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.33.0 to 0.35.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.33.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-version: 0.35.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/go_modules/golang.org/x/text-0.35.0 branch from 8871f16 to df5b8a9 Compare March 31, 2026 18:00
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign rcampos2029 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 13, 2026

Superseded by #1090.

@dependabot dependabot Bot closed this Apr 13, 2026
@dependabot dependabot Bot deleted the dependabot/go_modules/golang.org/x/text-0.35.0 branch April 13, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants