Skip to content

Remove legacy type checking code and update documentation#5216

Draft
yuancu wants to merge 1 commit intoopensearch-project:feature/validationfrom
yuancu:subpr-d
Draft

Remove legacy type checking code and update documentation#5216
yuancu wants to merge 1 commit intoopensearch-project:feature/validationfrom
yuancu:subpr-d

Conversation

@yuancu
Copy link
Collaborator

@yuancu yuancu commented Mar 9, 2026

Summary

Sub-PR 4/4 for #4892 — splitting the large PR into reviewable pieces targeting feature/validation.

This PR removes legacy type checking code that is no longer needed after migrating to Calcite's validation system, and updates user-facing documentation.

Deletions

  • PPLTypeChecker.java (701 lines) — Legacy type checker interface, replaced by Calcite's operand type checking
  • CalciteFuncSignature.java — Unused after PPLFuncImpTable simplification in Sub-PR B
  • CoercionUtils.java (old location) — Functionality moved to calcite/validate/ package in Sub-PR A
  • OpenSearchSparkSqlDialect.java (old ppl/ location) — Moved to core/calcite/validate/ in Sub-PR A
  • LambdaUtils.java — Lambda inference methods consolidated into TransformFunctionImpl/ReduceFunctionImpl

Documentation Updates

  • docs/dev/ppl-functions.md
  • docs/user/ppl/cmd/bin.md
  • docs/user/ppl/cmd/patterns.md
  • docs/user/ppl/functions/collection.md
  • docs/user/ppl/functions/conversion.md
  • docs/user/ppl/interfaces/endpoint.md

Dependency

Signed-off-by: Yuanchun Shen yuanchu@amazon.com

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 0fec295.

'Diff too large, requires skip by maintainers after manual review'


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit f2015e5.

'Diff too large, requires skip by maintainers after manual review'


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

- Remove PPLTypeChecker, CoercionUtils, CalciteFuncSignature (legacy type checking)
- Simplify LambdaUtils to remove PPLTypeChecker dependency
- Inline datetime widening logic in PPLFuncImpTable (replacing CoercionUtils call)
- Remove OpenSearchSparkSqlDialect (moved to core module)
- Update documentation for new validation pipeline
- Includes all changes from sub-PRs A, B, and C
@github-actions
Copy link
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 2538f95.

'Diff too large, requires skip by maintainers after manual review'


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant