Remove legacy type checking code and update documentation#5216
Remove legacy type checking code and update documentation#5216yuancu wants to merge 1 commit intoopensearch-project:feature/validationfrom
Conversation
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 0fec295. 'Diff too large, requires skip by maintainers after manual review' Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit f2015e5. 'Diff too large, requires skip by maintainers after manual review' Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
- Remove PPLTypeChecker, CoercionUtils, CalciteFuncSignature (legacy type checking) - Simplify LambdaUtils to remove PPLTypeChecker dependency - Inline datetime widening logic in PPLFuncImpTable (replacing CoercionUtils call) - Remove OpenSearchSparkSqlDialect (moved to core module) - Update documentation for new validation pipeline - Includes all changes from sub-PRs A, B, and C
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 2538f95. 'Diff too large, requires skip by maintainers after manual review' Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
Summary
Sub-PR 4/4 for #4892 — splitting the large PR into reviewable pieces targeting
feature/validation.This PR removes legacy type checking code that is no longer needed after migrating to Calcite's validation system, and updates user-facing documentation.
Deletions
PPLTypeChecker.java(701 lines) — Legacy type checker interface, replaced by Calcite's operand type checkingCalciteFuncSignature.java— Unused after PPLFuncImpTable simplification in Sub-PR BCoercionUtils.java(old location) — Functionality moved tocalcite/validate/package in Sub-PR AOpenSearchSparkSqlDialect.java(oldppl/location) — Moved tocore/calcite/validate/in Sub-PR ALambdaUtils.java— Lambda inference methods consolidated intoTransformFunctionImpl/ReduceFunctionImplDocumentation Updates
docs/dev/ppl-functions.mddocs/user/ppl/cmd/bin.mddocs/user/ppl/cmd/patterns.mddocs/user/ppl/functions/collection.mddocs/user/ppl/functions/conversion.mddocs/user/ppl/interfaces/endpoint.mdDependency
feature/validationSigned-off-by: Yuanchun Shen yuanchu@amazon.com