Skip to content

[Backport 2.19-dev] [BugFix] Fix the bug when boolean comparison condition is simplifed to field#5122

Open
opensearch-trigger-bot[bot] wants to merge 1 commit into2.19-devfrom
backport/backport-5071-to-2.19-dev
Open

[Backport 2.19-dev] [BugFix] Fix the bug when boolean comparison condition is simplifed to field#5122
opensearch-trigger-bot[bot] wants to merge 1 commit into2.19-devfrom
backport/backport-5071-to-2.19-dev

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Feb 6, 2026

Backport 624f5e6 from #5071.

@github-actions
[BugFix] Fix the bug when boolean comparison condition is simplifed t…
b2e16a6 
…o field (#5071)

* Fix the bug when boolean comparison condition is simplifed to field

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Update tests and cover more cases

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Correct the logic of not boolean comparison

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add missing IS_FALSE RexNode translation

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Remove unnecessary boolean expression conversion

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Refactor PredicateAnalyzer logic a bit

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add more strict not expression match for field

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check and flaky test

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Cover more cases for IS_FALSE, IS_NOT_TRUE, IS_NOT_FALSE

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Complement the truth tests for expressions

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix logic

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Fix spotless check

Signed-off-by: Songkan Tang <songkant@amazon.com>

* Add additional boolean filter only pushdown explain test cases

Signed-off-by: Songkan Tang <songkant@amazon.com>

---------

Signed-off-by: Songkan Tang <songkant@amazon.com>
(cherry picked from commit 624f5e6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/backport-5071-to-2.19-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@songkant-aws
Copy link
Contributor

songkant-aws commented Feb 6, 2026

Manual fix for backport PR's compilation issue: #5124

@opensearch-trigger-bot
Copy link
Contributor Author

opensearch-trigger-bot bot commented Feb 20, 2026

This PR is stalled because it has been open for 2 weeks with no activity.

@dai-chen
Copy link
Collaborator

dai-chen commented Mar 10, 2026

@songkant-aws We've stopped backporting to 2.19-dev. Anything here we want to backport?

@songkant-aws
Copy link
Contributor

songkant-aws commented Mar 11, 2026

@dai-chen No, we don't want to backport. It's just I don't have permission to close this PR.

@LantaoJin
Copy link
Member

LantaoJin commented Mar 13, 2026

@dai-chen No, we don't want to backport. It's just I don't have permission to close this PR.

we don't want to backport feature, but this is a bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@songkant-aws @dai-chen @LantaoJin