Draft
Conversation
rebkwok
commented
Apr 2, 2026
| # We currently don't have permission to create tables in the EMIS | ||
| # staging db. | ||
| if self.backend.display_name == "EMISV2": | ||
| return query.alias() |
Contributor
Author
There was a problem hiding this comment.
Note: you need this (atm) in order to try running ehrql against the staging db locally. We don't want to put it into the actual code because we expect to to be able to create tables, so we want to run tests using the create-tables code. (We might need some modification in order to create them in another schema.)
4 tasks
Contributor
|
Moved the codebase changes to #2746; I did not repeat the instructions for local connection there (but I verified that they work for me too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The absolute minimum needed to create an EMIS V2 backend that can be used to run the smoketest dataset definition against the EMIS test database.
To test the connection:
To run the smoketest dataset definition:
We don't have permission to create tables in the test db, hence the change to the Trino query engine; we should assume we will have that permission eventually, so that's just a workaround to get it working.
The patient table in the test db also has no date_of_birth values (it's null for every patient), so if you want to see it return anything from the smoketest dataset definition, you'll need to modify the population definition there.