Change document_of field choices#28
Open
andrey484 wants to merge 4 commits intoopenprocurement:masterfrom
Open
Change document_of field choices#28andrey484 wants to merge 4 commits intoopenprocurement:masterfrom
andrey484 wants to merge 4 commits intoopenprocurement:masterfrom
Conversation
Scandie
approved these changes
Jan 28, 2019
oleksiyVeretiuk
requested changes
Jan 28, 2019
| @@ -191,7 +201,7 @@ def __local_roles__(self): | |||
| complaints = ListType(ModelType(dgfCDB2Complaint), default=list()) | |||
| contracts = ListType(ModelType(Contract), default=list()) | |||
Contributor
There was a problem hiding this comment.
Наскільки знаю в contracts й awards теж використовується dgfCDB2Document, чи не треба замінити documents й для цих моделей?
Contributor
Author
There was a problem hiding this comment.
Изменение типов документов для contracts и awards, прописано в другой задаче
Contributor
There was a problem hiding this comment.
Добре. Але ще мають бути міграції, щоб змінити вже існуючі об'єкти.
Contributor
Author
There was a problem hiding this comment.
Миграции думаю добавить отдельным pull request -ом, cразу для всех отдельных pull request -ов для этого пакета
Contributor
There was a problem hiding this comment.
Ні міграції мають йти разом з змінами, які ти робиш бо в інакшому випадку твої зміни при викладені принесуть в систему некорректну роботу.
bdmbdsm
approved these changes
Mar 11, 2019
oleksiyVeretiuk
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.