Prohibition to remove startDate in tenderPeriod and enquiryPeriod#9
Open
karmagood wants to merge 2 commits intoopenprocurement:a172713223911293_add_default_enquiryPeriod.startDatefrom
Conversation
kroman0
requested changes
Mar 7, 2017
| Lot, schematics_embedded_role, schematics_default_role, ORA_CODES, WORKING_DAYS, | ||
| validate_features_uniq, validate_items_uniq, validate_lots_uniq, Period, | ||
| Complaint as BaseComplaint, TZ, get_now, set_parent, ComplaintModelType, | ||
| Complaint as BaseComplaint, TZ, get_now, set_parent, ComplaintModelType, CANT_DELETE_PERIOD_START_DATE_FROM, |
Contributor
There was a problem hiding this comment.
тут має бути свій CANT_DELETE_PERIOD_START_DATE_FROM, оскільки ми не знаємо термів введення цієї зміни
kroman0
reviewed
Mar 7, 2017
| self.assertEqual(response.status, '200 OK') | ||
| self.assertEqual(response.json['data']["status"], "active.tendering") | ||
|
|
||
| def test_switch_to_tendering_auctionPeriod(self): |
Contributor
There was a problem hiding this comment.
Тести мають бути часозалежні
kroman0
reviewed
Mar 7, 2017
|
|
||
| class AuctionSwitchtenderingResourceTest(BaseAuctionWebTest): | ||
|
|
||
| def test_switch_to_tendering_by_enquiryPeriod_endDate(self): |
Contributor
There was a problem hiding this comment.
Тести мають бути часозалежні
kroman0
reviewed
Mar 7, 2017
| self.assertEqual(response.content_type, 'application/json') | ||
| self.assertEqual(response.json['errors'][0]["description"], "Can't update auction in current (complete) status") | ||
|
|
||
| @unittest.skipIf(get_now() < CANT_DELETE_PERIOD_START_DATE_FROM, |
Contributor
There was a problem hiding this comment.
Тести мають бути часозалежні
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is