feature Awarding X plugin stage 1 *draft*#225
Open
antonkorobko wants to merge 3 commits intoopenprocurement:masterfrom
Open
feature Awarding X plugin stage 1 *draft*#225antonkorobko wants to merge 3 commits intoopenprocurement:masterfrom
antonkorobko wants to merge 3 commits intoopenprocurement:masterfrom
Conversation
Pull Request Test Coverage Report for Build 812
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 812
💛 - Coveralls |
oleksiyVeretiuk
requested changes
Jan 31, 2019
|
|
||
|
|
||
| @implementer(IAwardVX) | ||
| class Award(BaseAward): |
Contributor
There was a problem hiding this comment.
З того, що я розумію то цей awarding відрізняється від awarding_3_1 довжиною періодів. Але ці періоди конфігуруються в кінцевих пакунках, як зроблено в rubble. Чи є якась причина робити копію awarding_3_1 чи тут є зміни, які не дають змогу застосувати awarding_3_1
Contributor
There was a problem hiding this comment.
І мають бути міграції, щоб перевести існуючі awards 2_1 до 3_1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is