test: replace live API calls with proper mocks in test_api_calls#1680
Open
aryarathoree wants to merge 1 commit intoopenml:mainfrom
Open
test: replace live API calls with proper mocks in test_api_calls#1680aryarathoree wants to merge 1 commit intoopenml:mainfrom
aryarathoree wants to merge 1 commit intoopenml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With reference to issue #1649
Metadata
test_api_callsDetails
This PR removes live API dependencies from
tests/test_openml/test_api_calls.pyand replaces them with properly scoped mocks.Changes include:
requests.Sessioninstead of performing real HTTP requests.OpenMLNotAuthorizedError.@pytest.mark.test_serverdecorators.mtimeinstead ofctime.No production code was modified. All changes are limited to test improvements. Happy to make changes based on feedback. Thankyou!