[MNT] Replace live server call with mock in test_evaluation_list_filter_run#1672
Open
anuj452005 wants to merge 1 commit intoopenml:mainfrom
Open
[MNT] Replace live server call with mock in test_evaluation_list_filter_run#1672anuj452005 wants to merge 1 commit intoopenml:mainfrom
anuj452005 wants to merge 1 commit intoopenml:mainfrom
Conversation
…duction server dependency
Author
|
@geetu040 Hi !! can you please give review . |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
What does this PR implement/fix?
Converts test_evaluation_list_filter_run in tests/test_evaluations/test_evaluation_functions.py
from a
@pytest.mark.production_servertest (requiring a live connection to openml.org)into an offline unit test using
unittest.mock.What was changed?
TestEvaluationFunctions.test_evaluation_list_filter_run(production_server class method)@mock.patch.object(requests.Session, "get")Note: __list_evaluations makes two sequential GET calls internally (evaluation list + user lookup),
so both are intercepted using
mock_get.side_effect = [eval_response, user_response].How to reproduce / verify: