Improve validation of required attributes in OpenMLSplit ARFF parsing#1667
Open
vishwas-droid wants to merge 3 commits intoopenml:mainfrom
Open
Improve validation of required attributes in OpenMLSplit ARFF parsing#1667vishwas-droid wants to merge 3 commits intoopenml:mainfrom
vishwas-droid wants to merge 3 commits intoopenml:mainfrom
Conversation
Author
|
CC @geetu040 just a small ping on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves validation logic in OpenMLSplit.
Adds an explicit check for required ARFF attributes ("type", "rowid",
"repeat", "fold") before indexing into them. This avoids relying on
implicit list.index() errors and provides a clearer error message.
Replaces an empty ValueError with a more informative message when
repetitions contain inconsistent numbers of folds.
No behavioral changes are intended — this only improves clarity and
error reporting. Existing split-related tests pass.