Conversation
…into issue1564
for more information, see https://pre-commit.ci
This reverts commit 7ac1672.
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
please sync with base PR and update with these comments #1576 (comment)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 52 out of 53 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| configurable_fields = [f for f in config._defaults if f not in ["max_retries"]] | ||
| configurable_fields = [ | ||
| f.name for f in fields(openml._config.OpenMLConfig) if f.name not in ["max_retries"] |
There was a problem hiding this comment.
The code filters out a field named 'max_retries', but the OpenMLConfig dataclass does not contain a field with this name. The actual field is connection_n_retries. This filter condition should be updated to match the actual field name or removed if no longer needed.
| f.name for f in fields(openml._config.OpenMLConfig) if f.name not in ["max_retries"] | |
| f.name | |
| for f in fields(openml._config.OpenMLConfig) | |
| if f.name not in ["connection_n_retries"] |
| # Example script which will appear in the upcoming OpenML-Python paper | ||
| # This test ensures that the example will keep running! | ||
| with overwrite_config_context( | ||
| with openml.config.overwrite_config_context( # noqa: F823 |
There was a problem hiding this comment.
The # noqa: F823 comment appears incorrect for this context. F823 is a Flake8 error code for "local variable referenced before assignment", which doesn't apply here. This line should likely use # noqa: F401 (unused import) if anything, but since openml is used on line 12, it's likely not needed at all and should be removed.
Metadata
Details
fixes #1624