Skip to content

[ENH] V1 → V2 API Migration - Tasks#1611

Open
satvshr wants to merge 239 commits intoopenml:mainfrom
satvshr:tasks
Open

[ENH] V1 → V2 API Migration - Tasks#1611
satvshr wants to merge 239 commits intoopenml:mainfrom
satvshr:tasks

Conversation

@satvshr
Copy link
Contributor

@satvshr satvshr commented Jan 9, 2026

Metadata

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 76.62100% with 256 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.57%. Comparing base (7feb2a3) to head (975734f).

Files with missing lines Patch % Lines
openml/_config.py 75.26% 71 Missing ⚠️
openml/_api/clients/http.py 69.86% 66 Missing ⚠️
openml/_api/resources/task.py 75.17% 36 Missing ⚠️
openml/tasks/task.py 23.52% 13 Missing ⚠️
openml/_api/resources/base/versions.py 85.71% 11 Missing ⚠️
openml/tasks/functions.py 16.66% 10 Missing ⚠️
openml/_api/setup/backend.py 83.33% 8 Missing ⚠️
openml/cli.py 0.00% 8 Missing ⚠️
openml/_api/resources/base/fallback.py 84.21% 6 Missing ⚠️
openml/_api/setup/builder.py 80.64% 6 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   52.82%   51.57%   -1.25%     
==========================================
  Files          37       61      +24     
  Lines        4371     5035     +664     
==========================================
+ Hits         2309     2597     +288     
- Misses       2062     2438     +376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geetu040 geetu040 mentioned this pull request Jan 9, 2026
25 tasks
Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sync with base PR and update with these comments #1576 (comment)

@satvshr
Copy link
Contributor Author

satvshr commented Feb 25, 2026

Below errors, caused by the lack of a v2 API endpoint, I assume:

FAILED tests/test_api/test_task.py::test_fallback_get_matches - AttributeError: 'str' object has no attribute 'value'
FAILED tests/test_api/test_task.py::test_fallback_get - AttributeError: 'str' object has no attribute 'value'

Following errors caused by the tests/test_api/test_versions.py file which I think we will be removing?

ERROR tests/test_api/test_versions.py::test_v1_publish - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v1_delete - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v2_publish - TypeError: Can't instantiate abstract class DummyTaskV2API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v1_tag - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v2_delete - TypeError: Can't instantiate abstract class DummyTaskV2API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v1_untag - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v2_tag - TypeError: Can't instantiate abstract class DummyTaskV2API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_v2_untag - TypeError: Can't instantiate abstract class DummyTaskV2API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_fallback_publish - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_fallback_delete - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_fallback_tag - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'
ERROR tests/test_api/test_versions.py::test_fallback_untag - TypeError: Can't instantiate abstract class DummyTaskV1API without an implementation for abstract methods 'get', 'list'

@geetu040
Copy link
Collaborator

These are now fixed in the base PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for fallback tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - tasks

7 participants