[ENH] V1 → V2 API Migration - evaluation measures#1603
[ENH] V1 → V2 API Migration - evaluation measures#1603EmanAbdelhaleem wants to merge 94 commits intoopenml:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
==========================================
+ Coverage 52.04% 52.97% +0.92%
==========================================
Files 36 64 +28
Lines 4333 5082 +749
==========================================
+ Hits 2255 2692 +437
- Misses 2078 2390 +312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #1593
Depends on #1576
Related to #1575
f0c57de to
e091d57
Compare
6236112 to
a19cb35
Compare
|
@geetu040 Ready for review |
- removing this since it was not part of the sdk previously - some tests fail because of the timeout in stacked PRs - this option can easily be added if needed in future
geetu040
left a comment
There was a problem hiding this comment.
this looks good, some code is duplicated, let's wait for the design discussion
identified while debugging openml#1616 (comment)
geetu040
left a comment
There was a problem hiding this comment.
please sync with base PR and update with these comments #1576 (comment)
Fixes #1593
Depends on #1576
Related to #1575
Details
This PR implements
EvaluationMeasuresresource, and refactor its existing functions