do not mask SIGSEGV to hide real crash culprit/place#203
Open
kgardas wants to merge 2 commits intoopenlink:develop/7from
Open
do not mask SIGSEGV to hide real crash culprit/place#203kgardas wants to merge 2 commits intoopenlink:develop/7from
kgardas wants to merge 2 commits intoopenlink:develop/7from
Conversation
This patch fixes compilation issue on Solaris while using GNU C for compilation. Although this is not officially supported compiler for this OS still it is good to have it as a fall back option in case something's going wrong and you'd like to know if this is Solaris related issue or compiler related one. The fix is easy, Solaris does not provide NAN nor INFINITY defines so we're using those provided for WIN32. Please note that this is case only when compiling with GNU C. Sun's own C compiler supports both defines of course!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this solves issue #202