Better status reporting on initial config load#300
Open
bobjacobsen wants to merge 2 commits intoopenlcb:masterfrom
Open
Better status reporting on initial config load#300bobjacobsen wants to merge 2 commits intoopenlcb:masterfrom
bobjacobsen wants to merge 2 commits intoopenlcb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when you opened a CDI configuration window, the window status would show the CDI loading, but the window would then display while all the configuration values load in the background. This could lead to various problems if the user interacted with the display before the relevant values were loaded.
With this PR, the window stays in status mode, not fully displaying, until the load of configuration data is complete. This can be a significant additional delay if loading from a node with a larger configuration memory, but it makes the result much safer.
To do this, additional properties are fired and listened-to.
In addition, a blank line will now be accepted as a comment when reading a backup file to restore it.