feat: added topology struct and basic validations#89
Draft
NamanBalaji wants to merge 1 commit intomainfrom
Draft
feat: added topology struct and basic validations#89NamanBalaji wants to merge 1 commit intomainfrom
NamanBalaji wants to merge 1 commit intomainfrom
Conversation
apatsap
requested changes
Mar 24, 2026
apatsap
left a comment
apatsap
left a comment
There was a problem hiding this comment.
Just one small NP.
Also, once @jithinkunjachan has merged the hierarchy, we need to extend the validation of the topology against the hierarchy. Till then its good
| } | ||
|
|
||
| // Vault holds storage backend configuration | ||
| type Vault struct { |
There was a problem hiding this comment.
NP
This is techinically the config of a Vault so I'd call it analog to Key where we call it KeySpec, thus I'd rename to VaultSpec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added base models and validations for
Topology,KeyBindingandHierarchySegment.