feat(securemem): add handler and dump protection tests#86
Open
jithinkunjachan wants to merge 4 commits intomainfrom
Open
feat(securemem): add handler and dump protection tests#86jithinkunjachan wants to merge 4 commits intomainfrom
jithinkunjachan wants to merge 4 commits intomainfrom
Conversation
- Introduce Handler, HandlerRequest, and HandlerResponse abstractions for secure memory operations in internal/securemem/handler.go. - Add comprehensive unit and benchmark tests for handler logic. - Implement dump protection analysis script and integration tests using Docker and testcontainers to verify memory and dump protection. - Provide readonly memory test to ensure secrets cannot be modified after marking as read-only. - Update Makefile and go.mod for new dependencies and build flags.
push-tags-from-workflow
bot
added
dependencies
jithinkunjachan
force-pushed
the
feat/add-memvault3
branch
from
8bc4438 to
4a902bc
Compare
apatsap
approved these changes
Mar 23, 2026
apatsap
left a comment
apatsap
left a comment
There was a problem hiding this comment.
Nice. I've added just some small NP (not big enough to now approve), if you could just change that
There was a problem hiding this comment.
NP:
can we name the folder readonly, then its consistent with the other one
NamanBalaji
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
while running the
internal/securemem/test/dump/dump_test.gogcore testin github we are getting the following errorSo we are skipping these test is CI , but in local it will run