Skip to content

feat: add unit tests ans some description. #37

Open
philipphombergersap wants to merge 1 commit intomainfrom
feature/addunittest
Open

feat: add unit tests ans some description. #37
philipphombergersap wants to merge 1 commit intomainfrom
feature/addunittest

Conversation

@philipphombergersap
Copy link
Copy Markdown
Contributor

@philipphombergersap philipphombergersap commented Feb 4, 2026

What this PR does / why we need it:

Adds focused unit tests to ensure core helper behavior is correct and stable:

- internal/helmutil/restgetter.go:
  - Validates REST config copy semantics (no mutation of base).
  - Verifies namespace propagation via RawKubeConfigLoader.
  - Ensures discovery client and REST mapper can be constructed.

- multicluster/secretprovider/provider.go:
  - Ensures clusters can be created from kubeconfig Secrets (default and namespaced keys).
  - Verifies Provider caching and List behavior.
  - Covers error case for missing kubeconfig key.

These tests improve confidence in helm integration and multicluster secret resolution without requiring a live cluster.

Special notes for your reviewer:


Release note:

add unit tests ans some description. 

@philipphombergersap philipphombergersap changed the title feat: add unit tests for RemoteRESTClientGetter and CRD management feat: add unit tests ans some description. Feb 4, 2026
@philipphombergersap philipphombergersap self-assigned this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant