7904175: Empty option value can crash jextract

[nizarbenalla]

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Passing empty option values to jextract causes it to crash, this patch prevent that to happen.

Please add the following to the description of the pull request:

1. A brief recap of the status quo, as it relates to the subject of the pull request.
2. A description of why the status quo is problematic.
3. A description of how this pull request addresses this issue.
4. If you ran into issues while making changes in the code that you had to work around,
   please mention these as well, as this helps reviewers understand the changes that have been made.

For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive
problem description.

Please test your pull request before submitting it by running ./gradlew jtreg. If you're
not able to test locally on your machine, please indicate this in the pull request description,
and indicate which testing has been done instead (or indicate that no testing has been done).

It is possible to run tests through Github actions if you enable them for your fork (this is free).
Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run
automatically after the pull request has been created.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (no review required)

Issue

• CODETOOLS-7904175: Empty option value can crash jextract (Bug - P4)

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.org/jextract.git pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/303.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nizarbenalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904175: Empty option value can crash jextract

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ad6430f: Print IncludeKinds in consistent order
• aedcb82: 7904115: Fix for AIX test case failures due to incorrect alignment for double and pointer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (d2218ae8)

[JornVernee]

I'm not super familiar with the option parser code, but your changes look good to me.

[nizarbenalla]

Thank you for the review

/integrate

[openjdk]

@nizarbenalla
Your change (at version d2218ae) is now ready to be sponsored by a Committer.

[nizarbenalla]

/template append

[openjdk]

@nizarbenalla The pull request template has been appended to the pull request body

[nizarbenalla]

/integrate

[openjdk]

@nizarbenalla Your integration request cannot be fulfilled at this time, as the status check jcheck-openjdk/jextract-303 did not complete successfully

[mcimadamore]

/sponsor

[openjdk]

@mcimadamore This PR has not yet been marked as ready for integration.