Skip to content

Hide lobby card time badge when undefined and use lowercase s ✨#3348

Closed
FloPinguin wants to merge 1 commit intomainfrom
fix/lobby-card-time-badge
Closed

Hide lobby card time badge when undefined and use lowercase s ✨#3348
FloPinguin wants to merge 1 commit intomainfrom
fix/lobby-card-time-badge

Conversation

@FloPinguin
Copy link
Contributor

Description:

Fix lobby card time badge display

  • Hide the time badge entirely when no start time is available, instead of showing "-s" (looks weird)
  • Use normal-case on the badge so the "s" unit in durations (e.g. "45s") stays lowercase

Previous

image

Now

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

@FloPinguin FloPinguin added this to the v30 milestone Mar 4, 2026
@FloPinguin FloPinguin requested a review from a team as a code owner March 4, 2026 19:24
@FloPinguin FloPinguin added the UI/UX UI/UX changes including assets, menus, QoL, etc. label Mar 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

Walkthrough

The time display badge in the game mode selector now shows only when a valid time value exists, replacing undefined cases with an empty state. Font styling adjusted from uppercase to normal-case for improved presentation.

Changes

Cohort / File(s) Summary
Time Display Refinement
src/client/GameModeSelector.ts
Modified timeDisplay initialization to use empty string when undefined; conditional rendering only when truthy. Updated font styling from uppercase to normal-case for the time badge element.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

⏱️ When time is absent, silence speaks,
A badge that vanishes for weeks,
From UPPER shouts to normal grace,
The timer finds its proper place. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is well-detailed, explaining the purpose of changes with before/after screenshots and confirming all checklists are completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title directly addresses the main changes: hiding the time badge when undefined and using lowercase styling for the 's' unit.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FloPinguin FloPinguin changed the title fix: hide lobby card time badge when undefined and use lowercase s Hide lobby card time badge when undefined and use lowercase s ✨ Mar 4, 2026
@FloPinguin FloPinguin closed this Mar 5, 2026
@github-project-automation github-project-automation bot moved this from Triage to Complete in OpenFront Release Management Mar 5, 2026
@FloPinguin
Copy link
Contributor Author

no longer needed, evan did it in his homepage PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/UX UI/UX changes including assets, menus, QoL, etc.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

1 participant