Hide lobby card time badge when undefined and use lowercase s ✨#3348
Closed
FloPinguin wants to merge 1 commit intomainfrom
Closed
Hide lobby card time badge when undefined and use lowercase s ✨#3348FloPinguin wants to merge 1 commit intomainfrom
FloPinguin wants to merge 1 commit intomainfrom
Conversation
Contributor
WalkthroughThe time display badge in the game mode selector now shows only when a valid time value exists, replacing undefined cases with an empty state. Font styling adjusted from uppercase to normal-case for improved presentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
no longer needed, evan did it in his homepage PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix lobby card time badge display
normal-caseon the badge so the "s" unit in durations (e.g. "45s") stays lowercasePrevious
Now
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
FloPinguin