Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added map-generator/assets/maps/conakry/image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
115 changes: 115 additions & 0 deletions map-generator/assets/maps/conakry/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
{
"name": "conakry",
"nations": [
{
"coordinates": [20, 360],
"name": "Boffa",
"flag": "gn"
},
{
"coordinates": [510, 420],
"name": "Koba-Tatema",
"flag": "gn"
},
{
"coordinates": [680, 150],
"name": "Kenende",
"flag": "gn"
},
{
"coordinates": [1170, 30],
"name": "Dubreka",
"flag": "gn"
},
{
"coordinates": [1280, 280],
"name": "Tamouta",
"flag": "gn"
},
{
"coordinates": [1320, 550],
"name": "Ratoma",
"flag": "gn"
},
{
"coordinates": [1350, 40],
"name": "Coyah",
"flag": "gn"
},
{
"coordinates": [1630, 160],
"name": "Maferenya",
"flag": "gn"
},
{
"coordinates": [1730, 460],
"name": "Kaback",
"flag": "gn"
},
{
"coordinates": [2130, 80],
"name": "Forecariah",
"flag": "gn"
},
{
"coordinates": [2420, 424],
"name": "Benty",
"flag": "gn"
},
{
"coordinates": [2280, 440],
"name": "Laya",
"flag": "gn"
},
{
"coordinates": [1200, 910],
"name": "Fotoba",
"flag": "gn"
},
{
"coordinates": [1333, 835],
"name": "Ilot Cabri",
"flag": "gn"
},
{
"coordinates": [716, 260],
"name": "Bolonta",
"flag": "gn"
},
{
"coordinates": [870, 370],
"name": "Kanka",
"flag": "gn"
},
{
"coordinates": [940, 115],
"name": "Mangueya",
"flag": "gn"
},
{
"coordinates": [1975, 475],
"name": "Yelibane",
"flag": "gn"
},
{
"coordinates": [1900, 115],
"name": "Dandaya",
"flag": "gn"
},
{
"coordinates": [80, 480],
"name": "Marara",
"flag": "gn"
},
{
"coordinates": [390, 210],
"name": "Boufou",
"flag": "gn"
},
{
"coordinates": [180, 130],
"name": "Dioumaya",
"flag": "gn"
}
]
}
Comment on lines +1 to +115
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove the unrelated conakry generator asset from this PR.

This PR is wired for Dyslexdria, but this file adds a second map source named conakry. map-generator/main.go turns each assets/maps/<name>/info.json into generated map output, so keeping this here makes future generation produce conakry artifacts that are not part of the runtime map registration in this change. Please drop this file from the PR, or add the matching generated resources and game registration in the same PR if conakry is intentional.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@map-generator/assets/maps/conakry/info.json` around lines 1 - 115, This PR
accidentally adds a new map asset assets/maps/conakry/info.json (map name
"conakry") which will cause map-generator/main.go to produce unwanted generated
artifacts; either remove this file from the PR entirely, or if you intend to add
the Conakry map, include the corresponding generated outputs produced by
map-generator/main.go plus the runtime game/map registration (the same place
where "Dyslexdria" is registered) so the new map is fully wired in the same PR.

1 change: 1 addition & 0 deletions map-generator/assets/maps/conakry/temp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

Binary file added map-generator/assets/maps/dyslexdria/image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading