feat: remove ENABLE_COURSE_OUTLINE_NEW_DESIGN and ENABLE_UNIT_PAGE_NEW_DESIGN flags#2992
feat: remove ENABLE_COURSE_OUTLINE_NEW_DESIGN and ENABLE_UNIT_PAGE_NEW_DESIGN flags#2992rpenido wants to merge 2 commits intoopenedx:masterfrom
ENABLE_COURSE_OUTLINE_NEW_DESIGN and ENABLE_UNIT_PAGE_NEW_DESIGN flags#2992Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
2e6c6f7 to
491d50e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2992 +/- ##
==========================================
- Coverage 95.57% 95.38% -0.20%
==========================================
Files 1366 1364 -2
Lines 31507 31360 -147
Branches 6885 7065 +180
==========================================
- Hits 30113 29912 -201
- Misses 1344 1397 +53
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
491d50e to
896b190
Compare
edb003b to
68a3733
Compare
68a3733 to
f08f87b
Compare
ENABLE_COURSE_OUTLINE_NEW_DESIGNENABLE_COURSE_OUTLINE_NEW_DESIGN and ENABLE_UNIT_PAGE_NEW_DESIGN flags
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be linked here.
Useful information to include:
"Developer", and "Operator".
Supporting information
Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'