Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the simulation-data event payload typing by renaming the exported interface to better reflect that it represents an emitted event payload, and bumps package versions accordingly.
Changes:
- Rename the exported simulation-data payload type from
IOpenCORSimulationDatatoIOpenCORSimulationDataEvent. - Update internal Vue components to use the renamed type.
- Bump versions from
0.20260304.1to0.20260304.2in both root and renderer packages.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/views/SimulationExperimentView.vue | Updates simulation data helper return type/import to the renamed event payload type. |
| src/renderer/src/components/ContentsComponent.vue | Updates simulation data plumbing to use the renamed event payload type. |
| src/renderer/src/AppWithSimulationData.vue | Updates the @simulationData handler typing/usage to the renamed event payload type. |
| src/renderer/package.json | Bumps renderer package version. |
| src/renderer/index.ts | Renames the exported interface and updates the emit payload type. |
| src/renderer/index.d.ts | Updates the public type re-export to the renamed interface. |
| package.json | Bumps root package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.