Skip to content

Cleaning up#445

Merged
agarny merged 2 commits intoopencor:mainfrom
agarny:cleaning-up
Mar 4, 2026
Merged

Cleaning up#445
agarny merged 2 commits intoopencor:mainfrom
agarny:cleaning-up

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Mar 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 4, 2026 10:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the simulation-data event payload typing by renaming the exported interface to better reflect that it represents an emitted event payload, and bumps package versions accordingly.

Changes:

  • Rename the exported simulation-data payload type from IOpenCORSimulationData to IOpenCORSimulationDataEvent.
  • Update internal Vue components to use the renamed type.
  • Bump versions from 0.20260304.1 to 0.20260304.2 in both root and renderer packages.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/renderer/src/components/views/SimulationExperimentView.vue Updates simulation data helper return type/import to the renamed event payload type.
src/renderer/src/components/ContentsComponent.vue Updates simulation data plumbing to use the renamed event payload type.
src/renderer/src/AppWithSimulationData.vue Updates the @simulationData handler typing/usage to the renamed event payload type.
src/renderer/package.json Bumps renderer package version.
src/renderer/index.ts Renames the exported interface and updates the emit payload type.
src/renderer/index.d.ts Updates the public type re-export to the renamed interface.
package.json Bumps root package version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@agarny agarny merged commit f52fbdc into opencor:main Mar 4, 2026
12 checks passed
@agarny agarny deleted the cleaning-up branch March 4, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants