Improve on the method to retrieve simulation data from outside of OpenCOR#442
Improve on the method to retrieve simulation data from outside of OpenCOR#442agarny merged 4 commits intoopencor:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the public “retrieve simulation data” API so callers outside of OpenCOR can request data for multiple model parameters in one call, returning both the retrieved data and any issues encountered (per #441).
Changes:
- Update the exposed
simulationDataAPI acrossOpenCOR→ContentsComponent→SimulationExperimentViewto acceptstring[]and return a{ simulationData, issues }response object. - Add a new exported public type (
IOpenCORSimulationData) to describe the response shape. - Update the sample usage and bump package versions / lockfiles.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/views/SimulationExperimentView.vue | Aggregate simulation data retrieval for multiple parameters and return issues without rejecting. |
| src/renderer/src/components/OpenCOR.vue | Expose the new multi-parameter simulationData method and response type at the public component boundary. |
| src/renderer/src/components/ContentsComponent.vue | Forward the new simulationData(string[]) request through simulation-only mode, including retry behavior. |
| src/renderer/src/AppWithSimulationData.vue | Update example usage to request multiple parameters at once and log issues. |
| src/renderer/index.ts | Export the new IOpenCORSimulationData public interface. |
| src/renderer/package.json | Version bump for the renderer package. |
| package.json | Version bump and dev dependency patch update. |
| src/renderer/bun.lock | Lockfile updates. |
| bun.lock | Lockfile updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Fixes #441.