Add support for IN_CLUSTER_PROXY node type#681
Merged
NehaManjunath merged 14 commits intoopenconfig:mainfrom Apr 7, 2026
Merged
Add support for IN_CLUSTER_PROXY node type#681NehaManjunath merged 14 commits intoopenconfig:mainfrom
NehaManjunath merged 14 commits intoopenconfig:mainfrom
Conversation
- Update proto/topo.proto with `IN_CLUSTER_PROXY` in Vendor and `Node.Type` enums. - Create `topo/node/inclusterproxy` package implementing `Node` interface. - Set default image to `nicolaka/netshoot:latest` and enforce at least 1 `Service`. - Enforce link constraints to allow exactly one interface (`eth1`). - Add warning if `socat` is missing from `Command` or `Args`. - Update `topo/topo.go` to register the new node type. - Add unit tests in `topo/node/inclusterproxy/inclusterproxy_test.go`.
|
What does this do that simply configuring a HOST container doesn't already do? I see there's some basic validation (needs an eth1, needs a socat-based command) but does that warrant a dedicated node? |
- Update proto/topo.proto with `IN_CLUSTER_PROXY` in Vendor and `Node.Type` enums.
- Create `topo/node/inclusterproxy` package implementing `Node` interface.
- Set default image to `nicolaka/netshoot:latest` and enforce at least 1 `Service`.
- Enforce link constraints to allow exactly one interface (`eth1`).
- Enforce that `proxy-pool-for` label is present in static configuration.
- Add static validation assuring `eth1` is connected directly to the node given in `proxy-pool-for`.
- Add automatic `socat` command generation using `peer-ip` and `target-port` labels:
- Supports IPv4 address allocation arithmetic using `/31` masks.
- Adds IPv6 support using `/127` arithmetic and handles `TCP6-LISTEN` argument switches.
- Update `topo/topo.go` to register the new node type.
- Update `topo/topo.go` to register the new node type.
- Add unit tests in `topo/node/inclusterproxy/inclusterproxy_test.go`.
…into inclusterproxy
…into inclusterproxy
Contributor
|
/gcbrun |
…for in-cluster proxy nodes.
…into inclusterproxy
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
NehaManjunath
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IN_CLUSTER_PROXYin Vendor andNode.Typeenums.topo/node/inclusterproxypackage implementingNodeinterface.nicolaka/netshoot:latestand enforce at least 1Service.eth1).socatis missing fromCommandorArgs.topo/topo.goto register the new node type.topo/node/inclusterproxy/inclusterproxy_test.go.