fix(attestz): correct RPC name parsing during validation

[chitadi]

attestz-3 was failing due to a naming mismatch: the validate_readme_spec.go script expected RPC names like attestz.Service.Method, but when parsing the proto files, it was generating openconfig.attestz.Service.Method because of the package name defined in the proto. I updated the parsing logic to strip the openconfig. prefix, aligning the names, and the validation now passes correctly.

[gemini-code-assist]

Summary of Changes

Hello @chitadi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical validation failure in the attestz-3 system by refining the RPC name generation process. The core issue stemmed from a discrepancy between how RPC names were parsed from proto files and the format expected by validation scripts. By implementing a targeted modification to strip an unnecessary prefix from package names during parsing, the change ensures consistency in naming conventions, thereby enabling successful validation.

Highlights

• RPC Name Parsing Correction: The RPC name parsing logic was updated to correctly handle package names by stripping the 'openconfig.' prefix. This resolves a naming mismatch that caused validation failures in attestz-3.
• Validation Alignment: The change ensures that generated RPC names, such as 'openconfig.attestz.Service.Method', are aligned with the expected format 'attestz.Service.Method' for validation scripts like validate_readme_spec.go.

Changelog

• tools/internal/ocrpcs/visitor.go
  • Imported the 'strings' package to facilitate string manipulation.
  • Modified the VisitRPC method to check for and remove the 'openconfig.' prefix from the package name before constructing the full RPC name.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5133 / 3ace114

No tests identified for validation.

Help

[gemini-code-assist]

Code Review

This pull request correctly addresses a naming mismatch during RPC name parsing by stripping the openconfig. prefix. The change is functional and resolves the validation issue. The suggestion to make the code more concise by removing a redundant conditional check, which improves readability, remains valid.

[singhavnish2516]

lgtm