Skip to content

fix(hatch): clarify proof-passed egg status #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Takhoffman merged 1 commit into from
May 20, 2026
+19 −5
Merged

fix(hatch): clarify proof-passed egg status #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/clawsweeper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5933,7 +5933,8 @@ function publicPrEggLine(
}
const stateLines: Record<Exclude<PrEggState, "hatched">, string> = {
incubating: "🥚 Incubating: this PR egg is tucked into the review nest.",
warming: "🔥 Warming up: proof, findings, or rank-up moves are still in progress.",
warming:
"🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress.",
wobbling: "🔁 Wobbling: a re-review loop is active, so the shell is rattling.",
};
return [stateLines[state], "", hatchInstruction, ...explainer].join("\n");
Expand Down
21 changes: 17 additions & 4 deletions test/clawsweeper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3122,7 +3122,10 @@ Full review comments:

assert.doesNotMatch(comment, /\*\*PR egg\*\*/);
assert.match(eggComment, /ClawSweeper PR egg/);
assert.match(eggComment, /🔥 Warming up:/);
assert.match(
eggComment,
/🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress\./,
);
assert.doesNotMatch(eggComment, /```text/);
assert.match(eggComment, /<summary>What is this egg doing here\?<\/summary>/);
assert.match(eggComment, /Eggs appear after the PR passes real-behavior proof/);
Expand All @@ -3139,6 +3142,7 @@ Full review comments:
assert.match(eggComment, /Comment `@clawsweeper hatch` when this PR is/);
assert.match(eggComment, /🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary/);
assert.doesNotMatch(eggComment, /🎁 Pass real behavior proof/);
assert.doesNotMatch(eggComment, /proof, findings, or rank-up moves are still in progress/);
assert.doesNotMatch(eggComment, /✨ Hatched:/);
assert.doesNotMatch(eggComment, /Share on X:/);
});
Expand Down Expand Up @@ -3647,9 +3651,18 @@ Full review comments:
["automerge_armed", /✨ Hatched:/],
["ready_for_maintainer_look", /✨ Hatched:/],
["re_review_loop", /🔁 Wobbling:/],
["actively_grinding", /🔥 Warming up:/],
["waiting_on_author", /🔥 Warming up:/],
["needs_proof", /🔥 Warming up:/],
[
"actively_grinding",
/🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress\./,
],
[
"waiting_on_author",
/🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress\./,
],
[
"needs_proof",
/🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress\./,
],
[null, /🥚 Incubating:/],
] as const;

Expand Down
Loading