fix bugs#2
Open
tronpis wants to merge 5 commits intoopenclaw:mainfrom
Open
Conversation
Make Queue.Enqueue non-blocking when full and add unit tests
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
Avoid replaying unchanged file content in LineCapture path mode
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
kwasham
approved these changes
Mar 24, 2026
kwasham
left a comment
There was a problem hiding this comment.
PASS: Queue enqueue now drops tasks when full and the new tests cover both fullness and closed states. line_capture now debounces unchanged files, retries on stat/open, and the new tests verify it doesn't replay old content, which improves stability without exposing secrets or auth/RLS surface area. No status checks are configured (statusCheckRollup is empty).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LineCaptureis used with a regular file path and the file has not actually changed.Description
readPathLoopthat recordsModTimeandSizeand skips reopening regular files when both are unchanged while still bypassing the gate for pipes (os.ModeNamedPipe).scanReaderand keepreadReaderas the one-shot entry thatdefer-closes the output channel, and usescanReaderfrom the path loop to avoid multiple closers.time.Sleepcalls with a context-awaresleepWithContexthelper so backoff waits respect cancellation.TestLineCapturePathReopenStreamsMultipleLinesandTestLineCapturePathDoesNotReplayUnchangedFileinmodules/audio/line_capture_test.goto verify reopen behavior and that unchanged files do not replay.Testing
go test ./...and all packages passed, withmodules/audiopassing including the new regression tests.TestLineCapturePathDoesNotReplayUnchangedFileandTestLineCapturePathReopenStreamsMultipleLinescompleted successfully under the test run.