Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ef109f1f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
examples/flows/replay-viewer/src/hooks/use-run-bundle-loader.ts
Outdated
Show resolved
Hide resolved
|
Final report:
Validation run locally:
Codex review:
CI:
What I could not fully test locally:
This PR is ready for merge from my side. |
This comment has been minimized.
This comment has been minimized.
|
The Blacksmith failure note at #205 (comment) is outdated now. That websocket test failure was fixed on this branch and the current PR head |
Summary
live.jsonover stalerun.json, and preserve rewind behavior while new steps appendValidation
pnpm run format:checkpnpm run typecheckpnpm run lintpnpm run buildpnpm run viewer:typecheckpnpm run viewer:buildpnpm run testpnpm run check:docspnpm run build:test && node --test dist-test/test/replay-viewer-run-bundles.test.js dist-test/test/replay-viewer-view-model.test.js dist-test/test/replay-viewer-live-sync.test.jspnpm run build:test && node --test dist-test/test/replay-viewer-live-sync.test.js && pnpm run viewer:typecheckpnpm run viewer:preview,curl http://127.0.0.1:4173/api/runs, and a Nodewsclient againstws://127.0.0.1:4173/api/liveLocal caveat
pnpm run checkstill fails only attest:coverageunder local Nodev24.1.0because the built-in coverage runner reports the same bogus global coverage percentages this repo already sees locally even when all 444 tests pass. CI remains the real coverage gate because the repo’s coverage lane runs on Node 22.