feat(search): enhance playlist search with type filtering and badge styles#203
Closed
sreeshanth-soma wants to merge 4 commits intoopenbroadcaster:5.5-developfrom
Closed
feat(search): enhance playlist search with type filtering and badge styles#203sreeshanth-soma wants to merge 4 commits intoopenbroadcaster:5.5-developfrom
sreeshanth-soma wants to merge 4 commits intoopenbroadcaster:5.5-developfrom
Conversation
Member
Author
Member
|
Use dynamic icons from Font Awesome whenever possible https://fontawesome.com/search?q=live&ic=free-collection |
Member
Author
Add standard/playlist standard search aliases, consolidate badge styles into SCSS
aff36c0 to
3d6baf9
Compare
Member
Author
|
Thank you for the detailed feedback @hinanaya! I have addressed everything in the latest push
Regarding the PR workflow, that makes a lot of sense, and I was actually thinking along those same lines. I will try to group related changes into a single PR going forward, especially things like the search filters which all touch the same code. And whenever a PR gets merged, I will make sure to rebase the remaining ones so things stay clean. If I notice anything that needs adjusting during rebasing I will handle it right there. Appreciate the guidance on this 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Closes #118
Summary
Adds playlist-type aware search in the sidebar and introduces a visual type indicator for playlist search results.
Changes
Backend
core/models/playlists_model.phpbasic,b,pl b,playlist basic->standardadvanced,a,pl a,playlist advanced->advancedlive assist,liveassist,live_assist,la,pl la,playlist live assist->live_assistFrontend
public/js/sidebar.jsPL+Bfor standard/basicPL+Afor advancedPL+LAfor live assistdata-typeassignment for playlist results.public/scss/_sidebar.scssBehavior
basic,advanced,LA) now returns matching playlist types.Verification
basic,advanced, andla.PL+B/A/LA) next to playlist name.I chose subtle color-coded PL/B/A/LA badges to improve visual scanability in the playlist sidebar while keeping explicit text labels for clarity and accessibility.