fix: use codex-namespaced clientInfo.name instead of host application name#200
Open
liby wants to merge 1 commit intoopenai:mainfrom
Open
fix: use codex-namespaced clientInfo.name instead of host application name#200liby wants to merge 1 commit intoopenai:mainfrom
liby wants to merge 1 commit intoopenai:mainfrom
Conversation
… name The plugin currently sets `clientInfo.name` to `"Claude Code"`, which causes the app-server to present a `Claude Code/x.x.x` user-agent to upstream services. This is problematic for three reasons: 1. UA collision: Claude Code (Anthropic's CLI) already uses `Claude Code/x.x.x` as its own UA, making it impossible for upstream services to distinguish between native Claude Code requests and Codex requests routed through Claude Code. 2. Naming convention violation: every other Codex surface uses a `codex_*` / `Codex *` prefix (`codex_cli_rs`, `codex-tui`, `codex_vscode`, `Codex Desktop`). This plugin is the only one using the host application's name instead. 3. Compliance log misattribution: OpenAI's docs state that `clientInfo.name` feeds the Compliance Logs Platform. Using "Claude Code" incorrectly attributes Codex usage to a different vendor's product. Rename to `codex_claude_code` to follow the established `codex_` + host platform pattern (consistent with `codex_vscode`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
Summary
clientInfo.namefrom"Claude Code"to"codex_claude_code"inDEFAULT_CLIENT_INFOcodex_+ host platform naming convention used by all other Codex surfaces (codex_cli_rs,codex-tui,codex_vscode,Codex Desktop)Claude Code/x.x.xfor its own Anthropic API requests)Test plan
"Claude Code"value (clientInfois only consumed byDEFAULT_CLIENT_INFOand passed through toinitialize)node --checkpasses on the modified file/codex:reviewfrom Claude Code and verify the upstream request UA iscodex_claude_code/x.x.x