Skip to content

test: isolate saveState pruning test from shared git-repo state dir #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiayuuWang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: isolate saveState pruning test from shared git-repo state dir #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 69 additions & 54 deletions tests/state.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,65 +41,80 @@ test("resolveStateDir uses CLAUDE_PLUGIN_DATA when it is provided", () => {
});

test("saveState prunes dropped job artifacts when indexed jobs exceed the cap", () => {
// Use CLAUDE_PLUGIN_DATA to ensure the state directory is rooted inside the
// isolated temp workspace rather than in the shared git-repo-derived path.
// Without this, resolveWorkspaceRoot() climbs to the git repo root and all
// test runs share the same state dir, causing spurious extra files.
const workspace = makeTempDir();
const stateFile = resolveStateFile(workspace);
fs.mkdirSync(path.dirname(stateFile), { recursive: true });
const previousPluginDataDir = process.env.CLAUDE_PLUGIN_DATA;
process.env.CLAUDE_PLUGIN_DATA = workspace;

try {
const stateFile = resolveStateFile(workspace);
fs.mkdirSync(path.dirname(stateFile), { recursive: true });

const jobs = Array.from({ length: 51 }, (_, index) => {
const jobId = `job-${index}`;
const updatedAt = new Date(Date.UTC(2026, 0, 1, 0, index, 0)).toISOString();
const logFile = resolveJobLogFile(workspace, jobId);
const jobFile = resolveJobFile(workspace, jobId);
fs.writeFileSync(logFile, `log ${jobId}\n`, "utf8");
fs.writeFileSync(jobFile, JSON.stringify({ id: jobId, status: "completed" }, null, 2), "utf8");
return {
id: jobId,
status: "completed",
logFile,
updatedAt,
createdAt: updatedAt
};
});
const jobs = Array.from({ length: 51 }, (_, index) => {
const jobId = `job-${index}`;
const updatedAt = new Date(Date.UTC(2026, 0, 1, 0, index, 0)).toISOString();
const logFile = resolveJobLogFile(workspace, jobId);
const jobFile = resolveJobFile(workspace, jobId);
fs.writeFileSync(logFile, `log ${jobId}\n`, "utf8");
fs.writeFileSync(jobFile, JSON.stringify({ id: jobId, status: "completed" }, null, 2), "utf8");
return {
id: jobId,
status: "completed",
logFile,
updatedAt,
createdAt: updatedAt
};
});

fs.writeFileSync(
stateFile,
`${JSON.stringify(
{
version: 1,
config: { stopReviewGate: false },
jobs
},
null,
2
)}\n`,
"utf8"
);
fs.writeFileSync(
stateFile,
`${JSON.stringify(
{
version: 1,
config: { stopReviewGate: false },
jobs
},
null,
2
)}\n`,
"utf8"
);

saveState(workspace, {
version: 1,
config: { stopReviewGate: false },
jobs
});
saveState(workspace, {
version: 1,
config: { stopReviewGate: false },
jobs
});

const prunedJobFile = resolveJobFile(workspace, "job-0");
const prunedLogFile = resolveJobLogFile(workspace, "job-0");
const retainedJobFile = resolveJobFile(workspace, "job-50");
const retainedLogFile = resolveJobLogFile(workspace, "job-50");
const jobsDir = path.dirname(prunedJobFile);
const prunedJobFile = resolveJobFile(workspace, "job-0");
const prunedLogFile = resolveJobLogFile(workspace, "job-0");
const retainedJobFile = resolveJobFile(workspace, "job-50");
const retainedLogFile = resolveJobLogFile(workspace, "job-50");
const jobsDir = path.dirname(prunedJobFile);

assert.equal(fs.existsSync(retainedJobFile), true);
assert.equal(fs.existsSync(retainedLogFile), true);
assert.equal(fs.existsSync(retainedJobFile), true);
assert.equal(fs.existsSync(retainedLogFile), true);

const savedState = JSON.parse(fs.readFileSync(stateFile, "utf8"));
assert.equal(savedState.jobs.length, 50);
assert.deepEqual(
savedState.jobs.map((job) => job.id),
Array.from({ length: 50 }, (_, index) => `job-${50 - index}`)
);
assert.deepEqual(
fs.readdirSync(jobsDir).sort(),
Array.from({ length: 50 }, (_, index) => `job-${index + 1}`)
.flatMap((jobId) => [`${jobId}.json`, `${jobId}.log`])
.sort()
);
const savedState = JSON.parse(fs.readFileSync(stateFile, "utf8"));
assert.equal(savedState.jobs.length, 50);
assert.deepEqual(
savedState.jobs.map((job) => job.id),
Array.from({ length: 50 }, (_, index) => `job-${50 - index}`)
);
assert.deepEqual(
fs.readdirSync(jobsDir).sort(),
Array.from({ length: 50 }, (_, index) => `job-${index + 1}`)
.flatMap((jobId) => [`${jobId}.json`, `${jobId}.log`])
.sort()
);
} finally {
if (previousPluginDataDir == null) {
delete process.env.CLAUDE_PLUGIN_DATA;
} else {
process.env.CLAUDE_PLUGIN_DATA = previousPluginDataDir;
}
}
});