Skip to content

fix: empty allowed_channels denies all channels (secure by default) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaodu-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: empty allowed_channels denies all channels (secure by default) #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config.toml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[discord]
bot_token = "${DISCORD_BOT_TOKEN}"
# Required: at least one channel ID. Empty list = bot will not respond to any messages.
allowed_channels = ["1234567890"]

[agent]
Expand Down
6 changes: 4 additions & 2 deletions src/discord.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ impl EventHandler for Handler {
let bot_id = ctx.cache.current_user().id;

let channel_id = msg.channel_id.get();
let in_allowed_channel =
self.allowed_channels.is_empty() || self.allowed_channels.contains(&channel_id);
let in_allowed_channel = self.allowed_channels.contains(&channel_id);

let is_mentioned = msg.mentions_user_id(bot_id)
|| msg.content.contains(&format!("<@{}>", bot_id))
Expand Down Expand Up @@ -172,6 +171,9 @@ impl EventHandler for Handler {

async fn ready(&self, _ctx: Context, ready: Ready) {
info!(user = %ready.user.name, "discord bot connected");
if self.allowed_channels.is_empty() {
tracing::warn!("allowed_channels is empty — bot will NOT respond to any messages. Configure allowed_channels in config.toml.");
}
}
}

Expand Down