Skip to content

feat(discord): add configurable tool display#296

Open
chihkang wants to merge 2 commits intoopenabdev:mainfrom
chihkang:feat/tool-display-origin-main
Open

feat(discord): add configurable tool display#296
chihkang wants to merge 2 commits intoopenabdev:mainfrom
chihkang:feat/tool-display-origin-main

Conversation

@chihkang
Copy link
Copy Markdown

Summary

  • add reactions.tool_display with full, compact, and none modes
  • render compact Discord tool lines without full command arguments while keeping full for debugging
  • document the new setting in config.toml.example, README.md, and the Helm chart values/configmap

Testing

  • cargo test
  • rustfmt --edition 2021 --check src/config.rs src/discord.rs
  • git diff --check

Closes #216

@chihkang chihkang requested a review from thepagent as a code owner April 13, 2026 14:00
@thepagent
Copy link
Copy Markdown
Collaborator

Heads up — #253 just merged, which refactored compose_display() to add streaming-mode tool collapsing. This PR will have merge conflicts in src/discord.rs since both modify the same function.

When rebasing, please note:

  • compose_display() now takes a third streaming: bool parameter
  • Tool collapsing (threshold-based) is already handled for the streaming path
  • Your full/compact/none modes could layer on top nicely — compact could leverage the existing collapse logic, and none could skip tool rendering entirely

Please rebase on main and resolve conflicts. Happy to re-review after! 🙏

@thepagent thepagent added the p2 Medium — planned work label Apr 15, 2026
@chihkang chihkang force-pushed the feat/tool-display-origin-main branch from f6ea2bd to 037e6c0 Compare April 15, 2026 01:14
@github-actions github-actions bot added the closing-soon PR missing Discord Discussion URL — will auto-close in 3 days label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

⚠️ This PR is missing a Discord Discussion URL in the body.

All PRs must reference a prior Discord discussion to ensure community alignment before implementation.

Please edit the PR description to include a link like:

Discord Discussion URL: https://discord.com/channels/...

This PR will be automatically closed in 3 days if the link is not added.

@chihkang
Copy link
Copy Markdown
Author

Rebased onto main and resolved the compose_display() conflicts.

I kept the new streaming collapse behavior from #253 and layered the tool_display modes on top of it:

  • full preserves full tool titles
  • compact reuses the existing streaming collapse behavior while rendering compact labels for individual tool lines
  • none skips tool rendering entirely

I also synced Cargo.lock to the current 0.7.5 package version after rebasing.

Verification:

  • cargo test
  • rustfmt --edition 2021 --check src/config.rs src/discord.rs
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closing-soon PR missing Discord Discussion URL — will auto-close in 3 days p2 Medium — planned work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add tool_display config to control tool call visibility in Discord

2 participants