Add support for RoboCup 2D SAR data with restrictions#85
Merged
kenjiro-mk merged 1 commit intomasterfrom Apr 8, 2026
Merged
Conversation
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
SAR Class Test Results 📝
|
Collaborator
Author
|
@kenjiro-mk I have updated the PR as per your recommendation. I promptly request you to have a view at this request. |
kenjiro-mk
approved these changes
Apr 8, 2026
Collaborator
kenjiro-mk
left a comment
kenjiro-mk
left a comment
There was a problem hiding this comment.
SAR_class.py is good!
Next, please make soccer_SAR_class.py and others work with the RoboCup 2D data for SAR2RL as well.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SAR_class.py without removing the existing logic. I added robocup_2d handling so it is routed to Soccer_SAR_data only when preprocess_method='SAR2RL'.