Conversation
Added support for SAR2RL preprocessing method and improved error handling for the preprocessed directory.
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
kenjiro-mk
left a comment
kenjiro-mk
left a comment
There was a problem hiding this comment.
Doesn't SAR2RL only support RobCup2D data?
|
Is events.jsonl even necessary to run this code? |
|
Yes, SAR2RL only supports RobCup2D data. Do you want me to change anything in that? Please let me know if they are good enough. |
|
Also, I would like your reviews on their worth of integration. |
Refactor SAR2RL preprocessing method to enforce data provider restrictions and improve error handling for preprocessed directory.
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
|
Updated this. SAR2RL is now limited to data_provider='robocup_2d', and the code explicitly stops with a ValueError for any other provider. |
|
@kenjiro-mk Hope it is all good to merge now |
kenjiro-mk
left a comment
kenjiro-mk
left a comment
There was a problem hiding this comment.
Sorry to bother you again. Currently, the dataset and SAR2RL branching are handled in preprocessing/sports/SAR_data/soccer/soccer_SAR_class.py, but please modify this so that the branching is performed in preprocessing/sports/SAR_data/SAR_class.py instead.
| @@ -1,3 +1,6 @@ | |||
| Full current contents of `[soccer_SAR_class.py](/Users/akshatgarg/Desktop/PreProcessing/preprocessing/sports/SAR_data/soccer/soccer_SAR_class.py)`: | |||
There was a problem hiding this comment.
Please remove this code.
Init Test Results 📝
|
Init Test Results 📝
|
Init Test Results 📝
|
|
My apologies, Kenjiro san, as I was updating it on my local files, which might have been left during the editing process. |
|
Please make the following changes.
|
|
@kenjiro-mk Will be closing the PR as per your request. |
2 participants
NEW CHANGES