feat: improve library page layout with timeline and switch#368
Open
sumitakhuli wants to merge 2 commits intoopen-source-uom:mainfrom
Open
feat: improve library page layout with timeline and switch#368sumitakhuli wants to merge 2 commits intoopen-source-uom:mainfrom
sumitakhuli wants to merge 2 commits intoopen-source-uom:mainfrom
Conversation
Contributor
|
The button does not communicate its intent properly like the previous button and also when toggling between exam and courses period there is a layout shift(tested on IPhone 11 Pro from Firefox DevTools). If you can fix these two it should be fine. Also the layout on the contact info remains a bit awkward and could be fixed within this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Fixes #367 : Information Layout Too Dense by resigning the Library Page layout to be more visually organized and intuitive.
Key changes:
Switchcomponent to toggle between "Semester" and "Exam" periods.CalendarIcon,TimeIcon) to represent days.#0050e0, Syne font, high-contrast text).Related Issue
Fixes Issue #367: Information Layout Too Dense
Motivation and Context
The previous layout displayed opening hours and contact information in dense text blocks that were hard to scan. The period toggle was also small and easy to miss. This update improves readability and adds helpful visual cues for the user.
How Has This Been Tested?
Tested locally in the development environment:
Screenshots or GIF (In case of UI changes):
Before:
After:
Types of changes
Checklist: