Ruby 3 support#158
Conversation
|
Hi @brockfanning, this isn't working for me when I'm trying to make these changes. Here is the error that keeps coming up - https://github.com/ONSdigital/sdg-indicators/actions/runs/4993296549/jobs/8942200832?pr=3731. I've made a PR so you can check the files i've changed here. |
|
@sarah-beasley Thanks for testing. Can you also add these lines to your Gemfile: |
|
@brockfanning just added those lines and it errored very quickly - https://github.com/ONSdigital/sdg-indicators/actions/runs/5002864894/jobs/8963355031 , perhaps we need to specify the version of kramdown? |
|
@sarah-beasley Ah, I think we also need to specify the version of Jekyll. Can you try changing the Gemfile line about Jekyll to this? |
|
thanks @brockfanning that seems to have worked! fb here if you're interested |
sarah-beasley
left a comment
There was a problem hiding this comment.
this worked when testing on UK site when additional lines of code were included in the gemfile
This small code change seems to support the latest version of Ruby (3.2). To test this out with Ruby 3.2, you would need to point to this branch of jekyll-open-sdg-plugins in your Gemfile, such as:
And you would also need to adjust all of your Github Actions workflow files (eg,
.github/workflows/test-pull-requests.yml, and all of the others in that folder) to use Ruby 3, such as: