PreventionDisplayConfig.java null checks

[phc007]

Guard prevention display population against null names and incomplete immunization data to avoid inserting invalid entries into internal collections. This is necessary to allow for data migration from OSCAR 19 for users who have CVC style Preventions, otherwise the nulls cause havoc in prevention displays and will cause a 500 for oscarPrevention/index.jsp.

Bug Fixes:

Avoid adding prevention entries with null names to the prevention list and hash map to prevent null-related errors and invalid map keys.
Skip immunization-based prevention entries that lack a picklist name to avoid creating incomplete or invalid prevention records.

Description

Implemented null checks to prevent adding prevention entries with null names to the list and hash map.
Enhanced data integrity by skipping immunization-based prevention entries that lack a valid picklist name.
This change addresses issues related to null-related errors and invalid map keys.

line 167 is necessary to avoid picking up essentially partial data in CVC/NVC that don't map directly to a name
line 149 The first one is for symmetry although it is unlikely to be called as its based on XML configuration.

[phc007]

@warrendennis
this is copied from OSCAR 19 and is necessary if you are to support your own CVC data or that of OSCAR 19 users

[warrendennis]

Where is the NPE being caught?

A key cannot be null. A value should be null when it is null.
Wouldn't it be better to filter out ALL null keys BEFORE they are populated into the HashMap (goto line 224)?
If the CVC file did not include a 'name' key then it would be better to validate it with

HashMap.containsKey('name')

[phc007]

thanks for the review The null is in CVC data Its thrown in the index.page I will look at this and submit something better ... probably your suggestion

…

On Mon, Mar 9, 2026 at 7:23 PM Dennis Warren ***@***.***> wrote: *warrendennis* left a comment (open-osp/Open-O#212) <#212 (comment)> Where is the NPE being caught? A key cannot be null. A value should be null when it is null. Wouldn't it be better to filter out ALL null keys BEFORE they are populated into the HashMap (goto line 224)? If the CVC file did not include a 'name' key then it would be better to validate it with HashMap.containsKey('name') — Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACURMBLG44NHTRUKUEQPODD4P5G5JAVCNFSM6AAAAACWKR4JGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMRXGU3DSMJSG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>