Open
Conversation
Member
|
looks good to me, thanks 👍 I'll check it out on my machine later then merge |
Contributor
Author
Contributor
Author
@Valodim ? |
Contributor
Author
|
It's a pre work for modernize https://github.com/open-keychain/open-keychain |
|
Worked well for me but had to update |
Contributor
Author
|
Surprisingly, someone takes care about this pull request !
|
Without this option, bindToService fails on newer Android API versions.
I was having issues running the example application as it wouldn't connect to OpenKeychain. It wouldn't see OpenKeychain. As soon as I added this option, I was able to select OpenKeychain as my encryption provider. I sent you a PR with the recommended change. |
Fix bindToService on newer Android API versions
Move the queries from the example application into the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please see commit messages for details