Skip to content

chore: unleash integration test stability issues#374

Merged
toddbaert merged 1 commit intomainfrom
chore/unleash-test-stability
Mar 30, 2026
Merged

chore: unleash integration test stability issues#374
toddbaert merged 1 commit intomainfrom
chore/unleash-test-stability

Conversation

@toddbaert
Copy link
Copy Markdown
Member

This fails sometimes when CI is busy.

@toddbaert toddbaert requested review from a team as code owners March 30, 2026 17:37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a polling mechanism to ensure feature flags are fully propagated to the Unleash client API before integration tests proceed, which helps prevent flakiness. A review comment suggests improving error handling in the polling loop by catching specific network exceptions instead of a broad exception.

logger.info(
f"Waiting for flags; have {len(names)}/{len(EXPECTED_FLAGS)}"
)
except Exception as e:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Catching a broad Exception can hide unexpected issues and make debugging harder. It's generally better to catch more specific exceptions. For network-related issues during polling, requests.exceptions.RequestException is more appropriate.

Suggested change
except Exception as e:
except requests.exceptions.RequestException as e:

@toddbaert toddbaert force-pushed the chore/unleash-test-stability branch from 07b667d to 822429b Compare March 30, 2026 17:50
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the chore/unleash-test-stability branch from 822429b to b7e8762 Compare March 30, 2026 17:56
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.72%. Comparing base (7e18bc1) to head (b7e8762).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   90.16%   98.72%   +8.56%     
==========================================
  Files           1        3       +2     
  Lines         122      157      +35     
==========================================
+ Hits          110      155      +45     
+ Misses         12        2      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toddbaert toddbaert merged commit 6f96688 into main Mar 30, 2026
21 of 30 checks passed
@toddbaert toddbaert deleted the chore/unleash-test-stability branch March 30, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant