docs: ADR for modular flagd builder (OTel Collector-style)#1920
Draft
aepfli wants to merge 6 commits intoopen-feature:mainfrom
Draft
docs: ADR for modular flagd builder (OTel Collector-style)#1920aepfli wants to merge 6 commits intoopen-feature:mainfrom
aepfli wants to merge 6 commits intoopen-feature:mainfrom
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an Architecture Decision Record for a modular flagd builder, allowing users to create custom binaries with specific components to reduce dependency bloat. The review feedback suggests improving the consistency of the factory interfaces by using dependency structs for sync providers and evaluators, and notes the omission of the MiddlewareFactory interface. There is also a concern regarding the increased complexity in the Runtime struct when transitioning to a dynamic service registry.
Propose adopting an OTel Collector Builder-style approach for flagd, enabling users to compose custom binaries with only the sync providers, service endpoints, evaluators, and middleware they need. Key points: - Factory interfaces for all component types (sync, service, evaluator, middleware) - Each component becomes a separate Go module with its own go.mod - YAML manifest-driven code generation and compilation - Standard distributions (minimal, cloud, kubernetes, full) - User extensibility: custom components via own Go modules, no forking required Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
adr/modular-builder
branch
from
0a845e8 to
c46c10f
Compare
- Add telemetry.Provider interface and TelemetryFactory as 5th component type - Document current OTel coupling issues (global tracer, hardcoded otelgrpc/otelhttp) - Add telemetry/otel and telemetry/noop modules to module structure - Add telemetry column to standard distributions table - Add telemetry granularity open question - Inject telemetry into ServiceDependencies and EvaluatorFactory Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
- Use dependency structs for all factory Create methods (SyncDependencies, EvaluatorDependencies, MiddlewareDependencies) for consistency and forward compatibility - Add missing MiddlewareFactory interface definition - Address Runtime complexity concern: introduce EventBus for cross-service coordination instead of relying on typed method calls (e.g. Emit()), avoiding type assertions while keeping the dynamic service registry Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Analyze four options for how -f/--sources CLI flags interact with modular builds. Recommend Option A+D: keep -f as-is with fail-fast errors on unknown schemes, plus a 'flagd components' introspection command. Mirrors the OTel Collector's approach. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Keep it simple: a single telemetry.Provider interface covers both tracing and metrics. Independent selection can be revisited later. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Describe how the modular architecture enables a snapshot-based resilience pattern for high availability: - Snapshot writer subscribes to EventBus, persists flag state to disk - Snapshot sync provider loads cached state on startup as lowest- precedence source - flagd serves from cache immediately, live data overwrites when upstream connects - Composes with any sync provider, zero changes to store/evaluator Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ADR proposes adopting an OpenTelemetry Collector Builder-style modular build system for flagd.
Problem
flagd compiles all sync providers (file, HTTP, gRPC, Kubernetes, GCS, Azure Blob, S3), all service endpoints (flag-evaluation, OFREP, flag-sync), and their heavy dependencies (~700 transitive deps in
core/go.mod) into every binary — regardless of what the user needs.Proposed Solution
A
flagd-builderCLI tool that reads a YAML manifest and generates a custom flagd binary with only the selected components:Key Design Points
SyncFactory,ServiceFactory,EvaluatorFactory,MiddlewareFactory) for all component typesgo.modflagd-fullreplicates current behaviorOpen Questions (looking for feedback)
flagd-proxyalso use the builder?-f/--sourcesflagscc @open-feature/flagd-maintainers