Skip to content

fix: INFRA-1562 optimize prisma adapter for big queries #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sitozzz merged 1 commit into from
Apr 13, 2026
Merged

fix: INFRA-1562 optimize prisma adapter for big queries #7464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 50 additions & 20 deletions packages/keystone/databaseAdapters/adapters/PrismaAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,29 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
return { NOT: { [path]: { in: ids } } }
}

const _uniqueNonNull = values => {
const result = []
const seen = new Set()
for (const value of values) {
if (value === null || value === undefined) continue
if (seen.has(value)) continue
seen.add(value)
result.push(value)
}
return result
}

const _findManyWithChunking = async (model, query) => {
const normalizedQuery = {
...query,
where: query?.where || {},
}
const chunkedQueries = _buildChunkedFiltersForLargeIn(normalizedQuery)
if (!chunkedQueries) return model.findMany(normalizedQuery)
const parts = await Promise.all(chunkedQueries.map(chunkQuery => model.findMany(chunkQuery)))
return parts.flat()
Comment on lines +332 to +333
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve NOT semantics when chunking large filters

_findManyWithChunking always merges chunked queries with a union (parts.flat()), which changes semantics for negative predicates. For example, splitting where: { NOT: { id: { in: [...] } } } into chunks and unioning results returns (NOT chunk1) OR (NOT chunk2) instead of the required (NOT chunk1) AND (NOT chunk2), so large NOT ... in filters can match far too many rows. This path is now used by every-style relationship processing, so large inputs can produce incorrect query results.

Useful? React with 👍 / 👎.

}

const _isEmptyWhere = value =>
value === undefined ||
value === null ||
Expand All @@ -320,12 +343,12 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
if (!rel || !rel.left) return { id: { in: [] } }

const refListAdapter = this.getListAdapterByKey(fieldAdapter.refListKey)
const relatedRows = await refListAdapter.model.findMany({
const relatedRows = await _findManyWithChunking(refListAdapter.model, {
where: relWhere || {},
select: { id: true },
relationLoadStrategy: 'query',
})
const relatedIds = relatedRows.map(row => row.id).filter(v => v !== null && v !== undefined)
const relatedIds = _uniqueNonNull(relatedRows.map(row => row.id))

const isCurrentOnLeft = rel.left && rel.left.listKey === this.key && rel.left.path === fieldAdapter.path
const isCurrentOnRight = rel.right && rel.right.listKey === this.key && rel.right.path === fieldAdapter.path
Expand Down Expand Up @@ -359,14 +382,12 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
const oppositePath = isCurrentOnLeft ? rel.right?.path : isCurrentOnRight ? rel.left?.path : null
if (!oppositePath) return { id: { in: [] } }
const parentFkPath = _resolveRelationshipScalarPath(refListAdapter, oppositePath)
const parentIdRows = await refListAdapter.model.findMany({
const parentIdRows = await _findManyWithChunking(refListAdapter.model, {
where: relWhere || {},
select: { [parentFkPath]: true },
relationLoadStrategy: 'query',
})
const parentIds = parentIdRows
.map(row => row[parentFkPath])
.filter(v => v !== null && v !== undefined)
const parentIds = _uniqueNonNull(parentIdRows.map(row => row[parentFkPath]))

if (constraintType === 'is' || constraintType === 'some') {
return _idsToFilter('id', parentIds)
Expand All @@ -376,14 +397,12 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
}
if (constraintType === 'every') {
// every(X) == not exists related where not X
const notRows = await refListAdapter.model.findMany({
const notRows = await _findManyWithChunking(refListAdapter.model, {
where: { NOT: relWhere || {} },
select: { [parentFkPath]: true },
relationLoadStrategy: 'query',
})
const notParentIds = notRows
.map(row => row[parentFkPath])
.filter(v => v !== null && v !== undefined)
const notParentIds = _uniqueNonNull(notRows.map(row => row[parentFkPath]))
return _idsToFilter('id', notParentIds, { negate: true })
}
return _idsToFilter('id', parentIds)
Expand All @@ -406,10 +425,18 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
}

const schemaName = this.parentAdapter.dbSchemaName || 'public'
const placeholders = relatedIds.map((_, idx) => `$${idx + 1}`).join(', ')
const sql = `SELECT "${currentIdColumn}" AS "id" FROM "${schemaName}"."${rel.tableName}" WHERE "${relatedIdColumn}" IN (${placeholders})`
const rows = await this.parentAdapter.prisma.$queryRawUnsafe(sql, ...relatedIds)
const currentIds = rows.map(row => row.id).filter(v => v !== null && v !== undefined)
const queryLinkRowsByIds = async ids => {
const placeholders = ids.map((_, idx) => `$${idx + 1}`).join(', ')
const sql = `SELECT "${currentIdColumn}" AS "id" FROM "${schemaName}"."${rel.tableName}" WHERE "${relatedIdColumn}" IN (${placeholders})`
return this.parentAdapter.prisma.$queryRawUnsafe(sql, ...ids)
}
const linkRows = []
for (let i = 0; i < relatedIds.length; i += MAX_PRISMA_BIND_VALUES) {
const idsChunk = relatedIds.slice(i, i + MAX_PRISMA_BIND_VALUES)
const rowsPart = await queryLinkRowsByIds(idsChunk)
linkRows.push(...rowsPart)
}
const currentIds = _uniqueNonNull(linkRows.map(row => row.id))

if (constraintType === 'is' || constraintType === 'some') {
return _idsToFilter('id', currentIds)
Expand All @@ -418,17 +445,20 @@ PrismaListAdapter.prototype.processWheres = async function (where) {
return _idsToFilter('id', currentIds, { negate: true })
}
if (constraintType === 'every') {
const notRelatedRows = await refListAdapter.model.findMany({
const notRelatedRows = await _findManyWithChunking(refListAdapter.model, {
where: { NOT: relWhere || {} },
select: { id: true },
relationLoadStrategy: 'query',
})
const notRelatedIds = notRelatedRows.map(row => row.id).filter(v => v !== null && v !== undefined)
const notRelatedIds = _uniqueNonNull(notRelatedRows.map(row => row.id))
if (notRelatedIds.length === 0) return {}
const notPlaceholders = notRelatedIds.map((_, idx) => `$${idx + 1}`).join(', ')
const notSql = `SELECT "${currentIdColumn}" AS "id" FROM "${schemaName}"."${rel.tableName}" WHERE "${relatedIdColumn}" IN (${notPlaceholders})`
const notRows = await this.parentAdapter.prisma.$queryRawUnsafe(notSql, ...notRelatedIds)
const disallowedIds = notRows.map(row => row.id).filter(v => v !== null && v !== undefined)
const notLinkRows = []
for (let i = 0; i < notRelatedIds.length; i += MAX_PRISMA_BIND_VALUES) {
const idsChunk = notRelatedIds.slice(i, i + MAX_PRISMA_BIND_VALUES)
const rowsPart = await queryLinkRowsByIds(idsChunk)
notLinkRows.push(...rowsPart)
}
const disallowedIds = _uniqueNonNull(notLinkRows.map(row => row.id))
return _idsToFilter('id', disallowedIds, { negate: true })
}
return _idsToFilter('id', currentIds)
Expand Down
Loading