Skip to content

feat: rename whoami command to me for CLI consistency#160

Merged
rianjs merged 1 commit into
mainfrom
feat/159-whoami-to-me
May 19, 2026
Merged

feat: rename whoami command to me for CLI consistency#160
rianjs merged 1 commit into
mainfrom
feat/159-whoami-to-me

Conversation

@rianjs
Copy link
Copy Markdown
Collaborator

@rianjs rianjs commented May 19, 2026

Summary

slck used whoami for the identity command while every sibling CLI (cfl, jtk, gro, sfdc, nrcli) uses me. This renames the command to me and removes whoami entirely — no alias, no backwards compatibility (per issue #159).

Changes

  • Renamed package internal/cmd/whoami/internal/cmd/me/ (git mv, history preserved); whoamiOptionsmeOptions, WhoamiResultMeResult, runWhoamirunMe, Use: "me"
  • Updated registration in root.go and the noleak token-leak test
  • New TestRootRegistersMeNotWhoami in root_test.go asserts me is registered and no command is named or aliased whoami (locks the no-backwards-compat contract in CI)
  • Docs: README §Identity, integration-tests.md §9.1, and a ### Changed entry in the unreleased CHANGELOG section

Verification

  • make build / make test (739 pass) / make lint (0 issues) green
  • slck me and slck me -o json behave as the old whoami
  • slck whoamiunknown command
  • git grep -i whoami leaves only intentional refs (historical + new CHANGELOG entries, and the root test that asserts whoami is gone)

Closes #159

slck used `whoami` for the identity command while every sibling CLI
(cfl, jtk, gro, sfdc, nrcli) uses `me`. Rename to `me` and drop
`whoami` entirely — no alias, no backwards compatibility.

A root-command test asserts `me` is registered and `whoami` is gone
with no alias fallback.

Closes #159
@rianjs
Copy link
Copy Markdown
Collaborator Author

rianjs commented May 19, 2026

No findings.

The PR adheres to the architectural goal and product intent: whoami is removed from the command surface, me is registered as the replacement, no alias/back-compat path is introduced, docs are updated, and the root-level test now locks the no-alias contract in CI. The changes are scoped to the rename and supporting docs/tests; I don’t see drive-by behavior changes or speculative abstraction.

Verification note: GitHub CI was still in progress when I checked; the PR body’s local make build / make test / make lint claims are consistent with the diff but should still be allowed to finish before merge.

@rianjs
Copy link
Copy Markdown
Collaborator Author

rianjs commented May 19, 2026

TDD Coverage Assessment

Verdict: Adequate

  • All 6 existing runWhoami_* tests were renamed to runMe_* and continue to exercise the same behavior paths (bot-only, user-only, both, no tokens, auth failure, bot-without-bot-id). No coverage was lost.
  • TestRootRegistersMeNotWhoami in root_test.go explicitly locks the no-backwards-compat contract: asserts me is registered, asserts no command is named whoami, and asserts no command aliases whoami. This is exactly the right test for a hard-rename PR.
  • The noleak test was updated to reflect the renamed package — no regression there.
  • No new logic was introduced; this is a pure rename. No additional tests are warranted.

No gaps found.

STATUS: coverage=adequate gaps=0

Copy link
Copy Markdown

@monit-reviewer monit-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: bfd04aa

Summary

No issues found.

2 PR discussion threads considered.


Completed in 35s | $0.37 | sonnet | daemon 0.2.120 | Glorfindel
Field Value
Model sonnet
Reviewers hybrid-synthesis, documentation:docs-reviewer, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer, harness-engineering:harness-self-documenting-code-reviewer, security:security-code-auditor
Engine claude · sonnet
Reviewed by pr-review-daemon · monit-pr-reviewer
Duration 35s wall · 1m 01s compute (Reviewers: 28s · Synthesis: 4s)
Cost $0.37
Tokens 107.1k in / 4.4k out
Turns 7

Per-workstream usage

Workstream Model In Out Cache read Cache create Cost
hybrid-synthesis sonnet 27.9k 56 0 27.9k (1h) $0.11
documentation:docs-reviewer haiku 5.2k 2.7k 0 5.2k (1h) $0.02
harness-engineering:harness-architecture-reviewer sonnet 15.0k 77 2.1k 12.9k (1h) $0.06
harness-engineering:harness-enforcement-reviewer sonnet 15.0k 87 2.1k 12.9k (1h) $0.05
harness-engineering:harness-knowledge-reviewer sonnet 15.0k 76 2.1k 12.9k (1h) $0.06
harness-engineering:harness-self-documenting-code-reviewer sonnet 14.3k 82 2.1k 12.2k (1h) $0.05
security:security-code-auditor haiku 14.6k 1.2k 0 14.6k (1h) $0.03

Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.

@rianjs rianjs merged commit 289c3e3 into main May 19, 2026
2 checks passed
@rianjs rianjs deleted the feat/159-whoami-to-me branch May 19, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace whoami with me command for consistency with other CLIs

2 participants