feat: rename whoami command to me for CLI consistency#160
Conversation
slck used `whoami` for the identity command while every sibling CLI (cfl, jtk, gro, sfdc, nrcli) uses `me`. Rename to `me` and drop `whoami` entirely — no alias, no backwards compatibility. A root-command test asserts `me` is registered and `whoami` is gone with no alias fallback. Closes #159
|
No findings. The PR adheres to the architectural goal and product intent: Verification note: GitHub CI was still in progress when I checked; the PR body’s local |
TDD Coverage AssessmentVerdict: Adequate
No gaps found. STATUS: coverage=adequate gaps=0 |
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: bfd04aa
Summary
No issues found.
2 PR discussion threads considered.
Completed in 35s | $0.37 | sonnet | daemon 0.2.120 | Glorfindel
| Field | Value |
|---|---|
| Model | sonnet |
| Reviewers | hybrid-synthesis, documentation:docs-reviewer, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer, harness-engineering:harness-self-documenting-code-reviewer, security:security-code-auditor |
| Engine | claude · sonnet |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 35s wall · 1m 01s compute (Reviewers: 28s · Synthesis: 4s) |
| Cost | $0.37 |
| Tokens | 107.1k in / 4.4k out |
| Turns | 7 |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost |
|---|---|---|---|---|---|---|
| hybrid-synthesis | sonnet | 27.9k | 56 | 0 | 27.9k (1h) | $0.11 |
| documentation:docs-reviewer | haiku | 5.2k | 2.7k | 0 | 5.2k (1h) | $0.02 |
| harness-engineering:harness-architecture-reviewer | sonnet | 15.0k | 77 | 2.1k | 12.9k (1h) | $0.06 |
| harness-engineering:harness-enforcement-reviewer | sonnet | 15.0k | 87 | 2.1k | 12.9k (1h) | $0.05 |
| harness-engineering:harness-knowledge-reviewer | sonnet | 15.0k | 76 | 2.1k | 12.9k (1h) | $0.06 |
| harness-engineering:harness-self-documenting-code-reviewer | sonnet | 14.3k | 82 | 2.1k | 12.2k (1h) | $0.05 |
| security:security-code-auditor | haiku | 14.6k | 1.2k | 0 | 14.6k (1h) | $0.03 |
Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.
Summary
slckusedwhoamifor the identity command while every sibling CLI (cfl,jtk,gro,sfdc,nrcli) usesme. This renames the command tomeand removeswhoamientirely — no alias, no backwards compatibility (per issue #159).Changes
internal/cmd/whoami/→internal/cmd/me/(git mv, history preserved);whoamiOptions→meOptions,WhoamiResult→MeResult,runWhoami→runMe,Use: "me"root.goand thenoleaktoken-leak testTestRootRegistersMeNotWhoamiinroot_test.goassertsmeis registered and no command is named or aliasedwhoami(locks the no-backwards-compat contract in CI)### Changedentry in the unreleased CHANGELOG sectionVerification
make build/make test(739 pass) /make lint(0 issues) greenslck meandslck me -o jsonbehave as the oldwhoamislck whoami→unknown commandgit grep -i whoamileaves only intentional refs (historical + new CHANGELOG entries, and the root test that asserts whoami is gone)Closes #159